Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mylyn to packages #19

Closed
jonahgraham opened this issue May 4, 2023 · 7 comments · Fixed by #24 or #26
Closed

Add Mylyn to packages #19

jonahgraham opened this issue May 4, 2023 · 7 comments · Fixed by #24 or #26

Comments

@jonahgraham
Copy link
Contributor

Mylyn is back in 2023-06 M2. This issue is to track how/if we add it to the individual packages again.

Commit 711cdb4 was the one that removed it, but at that time different packages had a bunch of different subsets of Mylyn, with some packages having nothing.

Is there a single Mylyn feature that can simply be included everywhere that contains all or most all the key functionality?

I am soliciting feedback on the mailing list for a way forward.
@akurtakov
Copy link
Contributor

What is considered "key" functionality now is also critical ? Bugzilla ( I don't think so)? Github?

@guw
Copy link
Contributor

guw commented May 4, 2023 •
edited

+1 for committers package

@wimjongman
Copy link
Contributor

The key functionality is the internal rich task system. If you get used to it, the context system is very nice (it remembers the open files for a specific task). Also, the new GitHub and, Jenkins interfaces are great.

@jonahgraham jonahgraham mentioned this issue May 25, 2023
Closed
52 tasks
jonahgraham added a commit to jonahgraham/packages that referenced this issue May 25, 2023
@jonahgraham
Add Mylyn to EPP packages
e461877 
Summary of how and why I have added MyLyn to EPPs.

Below is all the mylyn features in 2023-06 M3 (not including wikitext stuff)

Included in all EPPs:

- org.eclipse.mylyn.ide_feature
- org.eclipse.mylyn.git
- org.eclipse.mylyn.hudson
- org.eclipse.mylyn.reviews.feature

Indirectly included in all EPPs because of a dependency chain starting above:

- org.eclipse.mylyn_feature
  - included as part of context_feature
- org.eclipse.mylyn.builds
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.identity
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.notifications
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.repositories
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.repositories.http
  - included as part of hudson
- org.eclipse.mylyn.context_feature
  - included as part of ide_feature
- org.eclipse.mylyn.discovery
  - included as part of mylyn_feature
- org.eclipse.mylyn.monitor
  - included as part of mylyn_feature
- org.eclipse.mylyn.tasks.ide
  - included as part of ide_feature
- org.eclipse.mylyn.team_feature
  - included as part of ide_feature
- org.eclipse.mylyn.versions
  - included as part of git

The following are in some of the EPPs, based on listed condition

- org.eclipse.mylyn.java_feature
  - if JDT is included
- org.eclipse.mylyn.pde_feature
  - if PDE is included
- org.eclipse.cdt.mylyn
  - if CDT is included

The following are not part of any of the EPPs, but can be installed from SimRel

- org.eclipse.mylyn.gerrit.dashboard.feature
- org.eclipse.mylyn.gerrit.feature
- org.eclipse.mylyn.trac_feature

Fixes eclipse-packaging#19
@jonahgraham jonahgraham mentioned this issue May 25, 2023
Merged
@jonahgraham
Copy link
Contributor Author

I have put together a PR in #24 which includes the reasoning for why I have included/excluded each of the mylyn features.

jonahgraham added a commit that referenced this issue May 25, 2023
@jonahgraham
Add Mylyn to EPP packages
3431d6a 
Summary of how and why I have added MyLyn to EPPs.

Below is all the mylyn features in 2023-06 M3 (not including wikitext stuff)

Included in all EPPs:

- org.eclipse.mylyn.ide_feature
- org.eclipse.mylyn.git
- org.eclipse.mylyn.hudson
- org.eclipse.mylyn.reviews.feature

Indirectly included in all EPPs because of a dependency chain starting above:

- org.eclipse.mylyn_feature
  - included as part of context_feature
- org.eclipse.mylyn.builds
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.identity
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.notifications
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.repositories
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.repositories.http
  - included as part of hudson
- org.eclipse.mylyn.context_feature
  - included as part of ide_feature
- org.eclipse.mylyn.discovery
  - included as part of mylyn_feature
- org.eclipse.mylyn.monitor
  - included as part of mylyn_feature
- org.eclipse.mylyn.tasks.ide
  - included as part of ide_feature
- org.eclipse.mylyn.team_feature
  - included as part of ide_feature
- org.eclipse.mylyn.versions
  - included as part of git

The following are in some of the EPPs, based on listed condition

- org.eclipse.mylyn.java_feature
  - if JDT is included
- org.eclipse.mylyn.pde_feature
  - if PDE is included
- org.eclipse.cdt.mylyn
  - if CDT is included

The following are not part of any of the EPPs, but can be installed from SimRel

- org.eclipse.mylyn.gerrit.dashboard.feature
- org.eclipse.mylyn.gerrit.feature
- org.eclipse.mylyn.trac_feature

Fixes #19
@jonahgraham
Copy link
Contributor Author

Reopening because simrel was missing some features - eclipse-mylyn/org.eclipse.mylyn#165

@jonahgraham jonahgraham reopened this May 26, 2023
@jonahgraham jonahgraham mentioned this issue May 26, 2023
Closed
@jonahgraham
Copy link
Contributor Author

@merks - I see in gerrit you added org.eclipse.oomph.setup.mylyn to SimRel - I assume that doesn't need to be in all the EPPs? If it should be in all EPPs, then should other org.eclipse.oomph.setup.* also be?

jonahgraham added a commit to jonahgraham/packages that referenced this issue May 26, 2023
@jonahgraham
Add Mylyn to EPP packages
907bd62 
(Follow up to eclipse-packaging#24 to add
additional features that were missing in SimRel 2023-06 M3)

Summary of how and why I have added MyLyn to EPPs.

Below is all the mylyn features in 2023-06 RC1 (not including wikitext stuff)

Included in all EPPs:

- org.eclipse.egit.mylyn
- org.eclipse.mylyn.ide_feature
- org.eclipse.mylyn.git
- org.eclipse.mylyn.github.feature
- org.eclipse.mylyn.hudson
- org.eclipse.mylyn.reviews.feature

Indirectly included in all EPPs because of a dependency chain starting above:

- org.eclipse.mylyn_feature
  - included as part of context_feature
- org.eclipse.mylyn.builds
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.identity
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.notifications
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.repositories
  - included as part of mylyn_feature
- org.eclipse.mylyn.commons.repositories.http
  - included as part of hudson
- org.eclipse.mylyn.context_feature
  - included as part of ide_feature
- org.eclipse.mylyn.discovery
  - included as part of mylyn_feature
- org.eclipse.mylyn.monitor
  - included as part of mylyn_feature
- org.eclipse.mylyn.tasks.ide
  - included as part of ide_feature
- org.eclipse.mylyn.tasks.index
  - contents of this feature are also included in mylyn_feature
- org.eclipse.mylyn.team_feature
  - included as part of ide_feature
- org.eclipse.mylyn.versions
  - included as part of git

The following are in some of the EPPs, based on listed condition

- org.eclipse.mylyn.java_feature
  - if JDT is included
- org.eclipse.mylyn.pde_feature
  - if PDE is included
- org.eclipse.cdt.mylyn
  - if CDT is included

The following are not part of any of the EPPs, but can be installed from SimRel

- org.eclipse.mylyn.bugzilla_feature
- org.eclipse.mylyn.gerrit.dashboard.feature
- org.eclipse.mylyn.gerrit.feature
- org.eclipse.mylyn.trac_feature
- org.eclipse.oomph.setup.mylyn

Due to this being activity tracking, but not making it obvious enough
that this it the purpose of the feature, this is being excluded for now:

- org.eclipse.mylyn.commons.activity
  - See eclipse-mylyn/org.eclipse.mylyn#172

Fixes eclipse-packaging#19
@jonahgraham jonahgraham mentioned this issue May 26, 2023
Merged
@merks
Copy link
Contributor

merks commented May 26, 2023

No don't add any other Oomph things to any packages. Thanks for asking. 😄

jonahgraham added a commit to jonahgraham/packages that referenced this issue Jun 5, 2023
@jonahgraham
Remove Mylyn from DSL package
ffec2a1 
Follow up to eclipse-packaging#19, eclipse-packaging#24, eclipse-packaging#26

Fixes eclipse-packaging#30
@jonahgraham jonahgraham mentioned this issue Jun 5, 2023
Merged
jonahgraham added a commit that referenced this issue Jun 7, 2023
@jonahgraham
Remove Mylyn from DSL package
1db1ea4 
Follow up to #19, #24, #26

Fixes #30
@jonahgraham jonahgraham mentioned this issue Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Mylyn to EPP packages jonahgraham/packages
Add Mylyn to EPP packages jonahgraham/packages
5 participants
@wimjongman @guw @merks @akurtakov @jonahgraham