-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slf4j configuration for php, committers and scout #47
Conversation
Because the slf4j.simple is not included "naturally" by any of the features already in php, committers or scout, include it explicitly here. Includes revert "Don't add slf4j.simple to products that don't include slf4j already" This reverts commit a196924. Fixes eclipse-packaging#27
@HannesWell this seems one way to resolve the problem I mentioned in #43 (comment) (part 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HannesWell this seems one way to resolve the problem I mentioned in #43 (comment) (part 1)
Yes this looks good.
Actually I expected that slf4j.api/simple will be pulled in from the eclipse/updates repo automatically.
Does the product contain any bundle that requires SLF4J?
AFAICT the bundles that worked (like cpp) pulled in slf4j.api/simple, but the others pulled in slf4j.api/nop without this change. I don't know how to track down the why though, so perhaps all packages (without logback) should have this slf4j.api/simple added to the product file? |
If slf4j.nop is available in the SimRel repo then it is probably random if simple or nop is included, unless some feature also includes slf4j.simple. |
I will create such a PR, thanks for offering though. It woul d be great if you could review it at some point though. |
Fixes eclipse-packaging#27 specifically a follow up for eclipse-packaging#47: eclipse-packaging#47 (comment)
Fixes eclipse-packaging#27 specifically a follow up for eclipse-packaging#47: eclipse-packaging#47 (comment)
Fixes #27 specifically a follow up for #47: #47 (comment)
Because the slf4j.simple is not included "naturally" by any of the features already in php, committers or scout, include it explicitly here.
Includes revert "Don't add slf4j.simple to products that don't include slf4j already" This reverts commit a196924.
Fixes #27