Bug 548113 - [Passage] create user from issue license wizard #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve Appearance class Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Rework BaseClassifierWizard to support InnerClassifierWizard Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Add InnerClassifierWizard and use it from IssueLicenseRequestPage Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
===========================================
- Coverage 9.39% 9.30% -0.10%
Complexity 105 105
===========================================
Files 476 493 +17
Lines 13482 13774 +292
Branches 1113 1127 +14
===========================================
+ Hits 1266 1281 +15
- Misses 12181 12458 +277
Partials 35 35
Continue to review full report at Codecov.
|
eparovyshnaya
added
the
pr::wip
Merge remote-tracking branch 'origin/master' into 548113/add_inner_wizard Conflicts: bundles/org.eclipse.passage.loc.users.ui/META-INF/MANIFEST.MF bundles/org.eclipse.passage.loc.users.ui/src/org/eclipse/passage/loc/internal/users/ui/i18n/UsersUiMessages.java bundles/org.eclipse.passage.loc.users.ui/src/org/eclipse/passage/loc/internal/users/ui/i18n/UsersUiMessages.properties Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Improve creation error handling Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Restore Appearance interface Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Fix "Select License Plan" functionality Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Conflicts: bundles/org.eclipse.passage.loc.workbench/src/org/eclipse/passage/loc/internal/workbench/wizards/BaseClassifierWizard.java bundles/org.eclipse.passage.loc.workbench/src/org/eclipse/passage/loc/internal/workbench/wizards/RootClassifierWizard.java Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Use ComposableClassMetadata Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Use container EClass name as a label until we have btter solution Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed
removed
the
pr::wip
...c.dashboard.ui/src/org/eclipse/passage/loc/dashboard/ui/wizards/IssueLicenseRequestPage.java
Show resolved
Hide resolved
eparovyshnaya
requested changes
Mar 29, 2020
...g.eclipse.passage.loc.users.ui/src/org/eclipse/passage/loc/internal/users/ui/SelectUser.java
Show resolved
Hide resolved
...g.eclipse.passage.loc.users.ui/src/org/eclipse/passage/loc/internal/users/ui/SelectUser.java
Outdated
Show resolved
Hide resolved
...pse.passage.loc.users.ui/src/org/eclipse/passage/loc/internal/users/ui/SelectUserOrigin.java
Show resolved
Hide resolved
...pse.passage.loc.users.ui/src/org/eclipse/passage/loc/internal/users/ui/SelectUserOrigin.java
Outdated
Show resolved
Hide resolved
...clipse.passage.loc.workbench/src/org/eclipse/passage/loc/internal/workbench/CreateInner.java
Outdated
Show resolved
Hide resolved
...clipse.passage.loc.workbench/src/org/eclipse/passage/loc/internal/workbench/SelectInner.java
Outdated
Show resolved
Hide resolved
...clipse.passage.loc.workbench/src/org/eclipse/passage/loc/internal/workbench/SelectInner.java
Show resolved
Hide resolved
....workbench/src/org/eclipse/passage/loc/internal/workbench/wizards/InnerClassifierWizard.java
Outdated
Show resolved
Hide resolved
...kbench/src/org/eclipse/passage/loc/internal/workbench/wizards/InnerClassifierWizardPage.java
Outdated
Show resolved
Hide resolved
Remove @SInCE 0.6 from internal Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
eparovyshnaya
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced basic implementation of "suggest to create an entity if not present during request to select"
In our case this is "Issue License" scenario: we need a User - and we will be asked to create User Origin first if not present.
Still a lot of things to be polished. Also requires a number of common packages to be created.
Please merge this one to create "a comma" for this long work.