PDE Javadoc issue in I20230405-1800

[vik-chand]

https://download.eclipse.org/eclipse/downloads/drops4/I20230405-1800/compilelogs/pde.doc.user.javadoc.txt

../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/RequiredPluginsClasspathContainer.java:18: error: package aQute.bnd.build does not exist
import aQute.bnd.build.Project;
^
../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndProjectManager.java:16: error: package aQute.bnd.build does not exist
import aQute.bnd.build.Container;
^
../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndProjectManager.java:17: error: package aQute.bnd.build.Container does not exist
import aQute.bnd.build.Container.TYPE;
^
../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndProjectManager.java:18: error: package aQute.bnd.build does not exist
import aQute.bnd.build.Project;
^
../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndProjectManager.java:19: error: package aQute.bnd.build does not exist
import aQute.bnd.build.Workspace;
^
../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndProjectManager.java:20: error: package aQute.bnd.osgi does not exist
import aQute.bnd.osgi.Constants;
^
../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndProjectManager.java:21: error: package aQute.bnd.osgi does not exist
import aQute.bnd.osgi.Processor;
^
../../../eclipse.pde/ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/bnd/BndProjectManager.java:48: error: cannot find symbol
private static Workspace workspace;

[laeubi]

I'll take a look, as the javadoc build is a bit special it might be that it requires an additional requirement.

[laeubi]

@vik-chand can you tell where the javadoc build is located?

[iloveeclipse]

See https://github.com/eclipse-platform/.github/wiki/Javadoc-validation#expected-flow - I've tried to reverse engineer the build in context of eclipse-jdt/eclipse.jdt.ui#484

Here the bnd library should be added to build classpath in bundles/org.eclipse.pde.doc.user/pdeOptions.txt

[laeubi]

Okay thanks I already feared it is related to that stuff ... I'll put this on my list of build issues that need to be reworked.

[laeubi]

I also have now requested the github checks plugin so we can get javadoc issues reported with Github PRs as well:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2920

[HannesWell]

I also have now requested the github checks plugin so we can get javadoc issues reported with Github PRs as well:

Thanks for that.

If the javadoc generation can be revived and simplified, wouldn't it them make sense to move https://github.com/eclipse-platform/eclipse.platform.common/tree/master/bundles/org.eclipse.pde.doc.user into this repo? And to do the same with the other doc bundles and the correpsonding repo so that the platform.common repo can become obsolete as well?

[iloveeclipse]

See eclipse-platform/eclipse.platform.common#137 with the fix.

[iloveeclipse]

Fixed in https://download.eclipse.org/eclipse/downloads/drops4/I20230408-1800