Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the build on API warnings #1077

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Jan 27, 2024

No description provided.

Copy link

github-actions bot commented Jan 27, 2024

Test Results

   279 files  ±0     279 suites  ±0   56m 23s ⏱️ -54s
 3 498 tests ±0   3 440 ✅ ±0   58 💤 ±0  0 ❌ ±0 
10 791 runs  ±0  10 615 ✅ ±0  176 💤 ±0  0 ❌ ±0 

Results for commit 3852204. ± Comparison against base commit b95c6e5.

♻️ This comment has been updated with latest results.

Suppress the existing API warnings and enable to fail on api warnings as
well.
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this.
Having those warnings strictly enforced is great!

@laeubi laeubi merged commit 6145788 into eclipse-pde:master Jan 27, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants