Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to runtime for annotations #1116

Merged

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Feb 3, 2024

No description provided.

Copy link

github-actions bot commented Feb 3, 2024

Test Results

   291 files  ±0     291 suites  ±0   52m 17s ⏱️ +29s
 3 526 tests ±0   3 468 ✅ ±0   58 💤 ±0  0 ❌ ±0 
10 875 runs  ±0  10 698 ✅ ±0  177 💤 ±0  0 ❌ ±0 

Results for commit 9aa9a2b. ± Comparison against base commit 0d546e9.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the fallback_to_runtime_for_annotations branch from 4eee660 to 3ca2c40 Compare February 4, 2024 23:12
@laeubi laeubi force-pushed the fallback_to_runtime_for_annotations branch from 3ca2c40 to ed3960f Compare February 11, 2024 06:37
If the annotations can't be found in the target platform currently no
automatic annotations are provided as part of the classpath container.

This now adds a fallback to the running eclipse instance to get the
annotations from there, this is similar on how Tycho works that loads
missing annotations from maven if they are not found in the target.
@laeubi laeubi force-pushed the fallback_to_runtime_for_annotations branch from ed3960f to 9aa9a2b Compare March 17, 2024 06:14
@laeubi laeubi merged commit ab28042 into eclipse-pde:master Mar 17, 2024
17 checks passed
@iloveeclipse
Copy link
Member

@laeubi : this PR most likely causes #1205. Could you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants