Synchronize values changed in the Overview with the instructions file #560
Conversation
Test Results 240 files ±0 240 suites ±0 1h 8m 7s ⏱️ + 11m 53s For more details on these errors, see this check. Results for commit ff03acb. ± Comparison against base commit 71e89bb. ♻️ This comment has been updated with latest results. |
|
@vik-chand @HannesWell it seems I missed the freeze yesterday, nerveless I wanted this to be merged as soon as possible, would you as PL approve this? Even though it might bee seen as a new feature, it also fixes some issues one currently see with using that feature as currently sometimes the manifest editor disappears and the manifest is not regenerated when things run "too fast" after each other and users might be confused when there changed values are not taken into account. |
There was a problem hiding this comment.
I only checked the existing code that is not only related to the new BND processing to ensure existing functionality is not broken and that looks good.
Since you just added the BND processing recently there is nothing to break that used to work in a previous release/milestone.
Therefore and since you said it contains fixes I'm fine with merging this today.
Only two remarks below. They are not critical but should be addressed eventually.
ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ManifestEditor.java
Outdated
Show resolved
Hide resolved
....eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/DependencyAnalysisSection.java
Show resolved
Hide resolved
Currently one can edit the instructions file and after safe the manifest is updated (and thus also the editor), but the other way does not work, if one for example edit the name in the overview page the changes are just overwritten on the next compile. This installs listeners and implements a very basic model for the instructions so changes are mirrored to the instructions file as it already happens for the MANIFEST.MF source tab.
Currently one can edit the instructions file and after safe the manifest is updated (and thus also the editor), but the other way does not work, if one for example edit the name in the overview page the changes are just overwritten on the next compile.
This installs listeners and implements a very basic model for the instructions so changes are mirrored to the instructions file as it already happens for the MANIFEST.MF source tab.