Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick-fix for extraneous empty line(s) in manifest editor #564

Merged

Conversation

gireeshpunathil
Copy link
Contributor

Extraneous lines are errneous to the manifest compiler, but it does not recommend / provide a resolution.
Add a quick fix to remove extraneous line.
Fixes: #563

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Test Results

   234 files  ±  0     234 suites  ±0   45m 0s ⏱️ + 3m 13s
3 278 tests  -   1  3 251 ✔️  -   2  24 💤 ±0  2 +1  1 🔥 ±0 
7 430 runs  +20  7 379 ✔️ +19  48 💤 ±0  2 +1  1 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit e34a248. ± Comparison against base commit 9cddd29.

This pull request removes 1 test.
AllPDEMinimalTests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@vik-chand vik-chand self-requested a review April 11, 2023 13:35
Copy link
Member

@vik-chand vik-chand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works wells, code looks good.

Few minor formatting issues and license year issue are there.

Extraneous lines are errneous to the manifest compiler,
but it does not recommend / provide a resolution.
Add a quick fix to remove extraneous line.
Fixes: eclipse-pde#563
1. code formatting
2. updating the copyright header
@gireeshpunathil
Copy link
Contributor Author

@vik-chand - address both he recommendations, please have a look.

@vik-chand vik-chand merged commit c5f499d into eclipse-pde:master Apr 11, 2023
6 of 8 checks passed
vik-chand added a commit that referenced this pull request Apr 12, 2023
vik-chand added a commit that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quick-fix for extraneous empty line(s) in manifest editor
2 participants