migrate to Java 17 switch semantics: extras #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace legacy switch block with java 17 semantics: 1. short-circuit initialization in the switch expression 2. default case match with the original initialization 3. reduce complex boolean expression to an elegant form Refs: eclipse-pde#570 (review)
merks
reviewed
Apr 13, 2023
ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/wizards/templates/PreprocessorParser.java
Outdated
Show resolved
Hide resolved
Test Results 234 files ±0 234 suites ±0 46m 47s ⏱️ +46s For more details on these failures and errors, see this check. Results for commit 1017fe0. ± Comparison against base commit 263fc98. ♻️ This comment has been updated with latest results. |
HannesWell
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace legacy switch block with java 17 semantics:
Refs: #570 (review)
/cc @HannesWell