Fix line number in error reporting during manifest validation:

[alshamams]

The plug-in manifest is validated in two phases: i) when it is first loaded, ii) when the manifest is inline edited. In the former case, the validation is carried out in OSGI layers, and the exception caught in the pde modules with no bearing on the faulty line number, in case of issues.

This commit tries to parse the exception message in a best effort basis, extracts the header that is subjected for the fault and obtains the line number of the header. It falls back on line 1, in case of parse error.

Fixes: #613

[github-actions]

Test Results

   237 files   -        6     237 suites   - 6   51m 6s ⏱️ - 3m 13s
3 286 tests +       1  3 260 ✔️ ±       0  24 💤 ±  0  2 ❌ +2 
7 431 runs   - 2 721  7 381 ✔️  - 2 698  48 💤  - 24  2 ❌ +2 

For more details on these failures, see this check.

Results for commit adcbe18. ± Comparison against base commit 57007dd.

♻️ This comment has been updated with latest results.

[vik-chand]

1. The variable names like t1,t2,hdr can be improved
2. StringTokenizer is legacy, split should be preferred
3. Also a short comment on what you are trying to achieve

[alshamams]

In some cases manifest validation takes place in the OSGI layers without obtaining the erroneous line number, as is the case with bundle description validation, thereby displaying it on line 1. This may lead to confusion regarding line number.
This commit tries to parse the exception message, extracts the header from the error message and obtains the line number of the header. It falls back on line 1, in case of parse error.

[vik-chand]

The declaration at line 149 could be moved down. Update license year if required.
split could be renamed as splitArray. Also one liner comment on what you are doing.

[alshamams]

Hi @vik-chand ,
Kindly look through the edits and let me know in case of any further changes.

[gireeshpunathil]

Suggested change

	IHeader header = null;
	header = getHeader(lastString);
	IHeader header = getHeader(lastString);

[vik-chand]

Please rebase wrt latest.