Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ClasspathContributor for API tools annotations #912

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Nov 12, 2023

Currently it is quite cumbersome to use and discover the PDE own API tools annotations and requires some kind of workarounds.

This adds a classpath contributor that makes the annotations available like already done for ds and bundle annotations.

Fix #447

Copy link

github-actions bot commented Nov 12, 2023

Test Results

     270 files  ±0       270 suites  ±0   48m 12s ⏱️ - 7m 26s
  3 327 tests ±0    3 297 ✔️ ±0  30 💤 ±0  0 ±0 
10 278 runs  ±0  10 188 ✔️ ±0  90 💤 ±0  0 ±0 

Results for commit 2264a6d. ± Comparison against base commit 62e8a76.

♻️ This comment has been updated with latest results.

laeubi added a commit to laeubi/tycho that referenced this pull request Nov 12, 2023
This adds a similar feature like PDE will offer soon see
eclipse-pde/eclipse.pde#912
@laeubi
Copy link
Contributor Author

laeubi commented Nov 12, 2023

laeubi added a commit to laeubi/tycho that referenced this pull request Nov 13, 2023
This adds a similar feature like PDE will offer soon see
eclipse-pde/eclipse.pde#912
laeubi added a commit to laeubi/tycho that referenced this pull request Nov 13, 2023
This adds a similar feature like PDE will offer soon see
eclipse-pde/eclipse.pde#912
laeubi added a commit to eclipse-tycho/tycho that referenced this pull request Nov 13, 2023
This adds a similar feature like PDE will offer soon see
eclipse-pde/eclipse.pde#912
laeubi added a commit to laeubi/tycho that referenced this pull request Nov 13, 2023
This adds a similar feature like PDE will offer soon see
eclipse-pde/eclipse.pde#912
laeubi added a commit to eclipse-tycho/tycho that referenced this pull request Nov 13, 2023
This adds a similar feature like PDE will offer soon see
eclipse-pde/eclipse.pde#912
Currently it is quite cumbersome to use and discover the PDE own API
tools annotations and requires some kind of workarounds.

This adds a classpath contributor that makes the annotations available
like already done for ds and bundle annotations.

Fix eclipse-pde#447
@laeubi laeubi merged commit 9c5301f into eclipse-pde:master Nov 29, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDE API-Tools should add api.tools.annotations on a Plug-ins classpath automatically
1 participant