Skip to content

Commit

Permalink
[Build] Don't resign already signed jars
Browse files Browse the repository at this point in the history
Reduce the number of actual signing operations by not re-signing
artifacts (in the I-build) are already signed, usually because they have
been 'baseline-replaced'.

The baseline replacement is performed first the 'p2-metadata-default'
goal executed by default and before the jar-signing.
The subsequent explicit invocation of the p2-metadata (non-default) goal
is again necessary to update the p2 metadata (like artifact size) after
the jar has been altered by the signing operation.

Fixes #2134
  • Loading branch information
HannesWell committed Jun 20, 2024
1 parent 88cff7a commit 213e6ff
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions eclipse-platform-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,7 @@
</execution>
</executions>
<configuration>
<resigningStrategy>DO_NOT_RESIGN</resigningStrategy>
<excludeInnerJars>${defaultSigning-excludeInnerJars}</excludeInnerJars>
<!--
The default timeout is 0 seconds which means "wait forever": https://www.eclipse.org/cbi/sitedocs/eclipse-jarsigner-plugin/sign-mojo.html#timeoutMillis
Expand Down

0 comments on commit 213e6ff

Please sign in to comment.