Skip to content

Commit

Permalink
Move 'tycho-apitools-plugin:generate' execution to build/plugins section
Browse files Browse the repository at this point in the history
The tycho-apitools-plugin:generate mojo already checks if a project has
a manifest file and if not silently skips its execution. Therefore it is
not necessary to guard it with a profile aciveted with the condition
'<file><exists>META-INF/MANIFEST.MF</exists></file>'
  • Loading branch information
HannesWell committed Mar 25, 2023
1 parent e413130 commit 3716733
Showing 1 changed file with 16 additions and 31 deletions.
47 changes: 16 additions & 31 deletions eclipse-platform-parent/pom.xml
Expand Up @@ -388,6 +388,22 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-apitools-plugin</artifactId>
<version>${tycho.version}</version>
<executions>
<execution>
<id>generate</id>
<goals>
<goal>generate</goal>
</goals>
<configuration>
<projectName>${project.artifactId}_${qualifiedVersion}</projectName>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
<pluginManagement>
<plugins>
Expand Down Expand Up @@ -762,37 +778,6 @@
</repository>
</repositories>
</profile>
<profile>
<id>api-generation</id>
<activation>
<!-- Does it have to be a profile if we can evaluate condition reliably in antrun? -->
<file><exists>META-INF/MANIFEST.MF</exists></file>
<property>
<name>!longnotexistingproperty</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-apitools-plugin</artifactId>
<version>${tycho.version}</version>
<executions>
<execution>
<id>generate</id>
<goals>
<goal>generate</goal>
</goals>
<configuration>
<skip>${skipAPIDescription}</skip>
<projectName>${project.artifactId}_${qualifiedVersion}</projectName>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>api-check</id>
<activation>
Expand Down

0 comments on commit 3716733

Please sign in to comment.