-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.31 I-Build: I20240114-1800 - BUILD FAILED #1724
4.31 I-Build: I20240114-1800 - BUILD FAILED #1724
Comments
regression from eclipse-platform/eclipse.platform.swt#973
|
That's unexpected, because in general it works to launch the Java script, as one can see at the SWT master branch build. I can investigate this in detail this evening, unless somebody else has fixed it in the meantime. But my current guess is that the Maven build is launched with an explicit java exe and not the default one on the system, which I assume is still Java-11. |
Since eclipse-platform/eclipse.platform.swt#973 the I-build (like the SWT build) requires a java-17 (or later) jdk on the PATH system environment-variable in order to launch a jdk>=17 with the 'java' command from the CLI. Just setting the JAVA_HOME variable to a path pointing to a jdk-17 is not sufficient since the the java executable is usually located in '$JAVA_HOME/bin'. And while the maven launch script searches in '$JAVA_HOME/bin' for a java executable to run the build itself, a simple java command on the CLI isn't that smart. Previously java would just run the default default java version on the Jenkins executor. In general this simplifies the build-configuration because the JDK to use is only defined once and used everywhere. Fixes eclipse-platform#1724
Since eclipse-platform/eclipse.platform.swt#973 the I-build (like the SWT build) requires a java-17 (or later) jdk on the PATH system environment-variable in order to launch a jdk>=17 with the 'java' command from the CLI. Just setting the JAVA_HOME variable to a path pointing to a jdk-17 is not sufficient since the the java executable is usually located in '$JAVA_HOME/bin'. And while the maven launch script searches in '$JAVA_HOME/bin' for a java executable to run the build itself, a simple java command on the CLI isn't that smart. Previously running the 'java' command would just run the default default java version on the Jenkins executor. In general this simplifies the build-configuration because the JDK to use is only defined once and used everywhere. Fixes eclipse-platform#1724
Since eclipse-platform/eclipse.platform.swt#973 the I-build (like the SWT build) requires a java-17 (or later) jdk on the PATH system environment-variable in order to launch a jdk>=17 with the 'java' command from the CLI. Just setting the JAVA_HOME variable to a path pointing to a jdk-17 is not sufficient since the the java executable is usually located in '$JAVA_HOME/bin'. And while the maven launch script searches in '$JAVA_HOME/bin' for a java executable to run the build itself, a simple java command on the CLI isn't that smart. Previously running the 'java' command would just run the default default java version on the Jenkins executor. In general this simplifies the build-configuration because the JDK to use is only defined once and used everywhere. Fixes #1724
After applying #1727 the newly triggered I-build failed with:
|
I replayed the I build with and without the new tools section echoing the value of
PATH is
and without PATH is just
So the tools are prepended as expected, but somehow the |
Is the path really multiline ? |
No it is linear. I just split it for better comparability. I now did some replays (with failure mails disabled to not spam everybody) and it looks like that the
Breaks the build, at least the replay https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/95/console makes me be believe it. |
If that's the case define just the jdk tool. |
Tried that with I-build-4.31#97. Fingers crossed. |
It would be nice if you open helpdesk issue so the issue can be investigated further. |
Done with https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4171. With I-build-4.31#97 the build of all the native swt fragments succeeded. Just created #1728 to fix the template with the changes from the replay. |
See https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/91/console
The text was updated successfully, but these errors were encountered: