Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I20240126-0330 is unstable #1750

Closed
iloveeclipse opened this issue Jan 26, 2024 · 5 comments
Closed

I20240126-0330 is unstable #1750

iloveeclipse opened this issue Jan 26, 2024 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@iloveeclipse
Copy link
Member

See

1.  eclipse.platform.ui/bundles/org.eclipse.ui.workbench/.polyglot.META-INF
   no-classifier: different
      org/eclipse/ui/internal/databinding/ActivePageProperty$1$1.class: different
      org/eclipse/ui/internal/databinding/ActivePartProperty$1$1.class: different
      org/eclipse/ui/internal/databinding/ActiveWindowProperty$1$1.class: different
      org/eclipse/ui/internal/dialogs/DecoratorsPreferencePage$2$1.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

2.  eclipse.platform.ui/bundles/org.eclipse.ui.ide/.polyglot.META-INF
   no-classifier: different
      org/eclipse/ui/internal/wizards/datatransfer/SmartImportRootWizardPage$16$1.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

3.  eclipse.jdt.ui/org.eclipse.jdt.jeview/.polyglot.META-INF
   no-classifier: different
      org/eclipse/jdt/jeview/views/JavaElementView$16$1.class: different
    The main artifact has been replaced with the baseline version.
    The following attached artifacts have been replaced with the baseline version: [sources]

Highly likely result of compiler fix eclipse-jdt/eclipse.jdt.core#1906.

I'm looking into.

@iloveeclipse iloveeclipse added the bug Something isn't working label Jan 26, 2024
@iloveeclipse
Copy link
Member Author

Highly likely result of compiler fix eclipse-jdt/eclipse.jdt.core#1906.

Yes, it is. All class changes are valid, i will touch related bundles now.

@iloveeclipse iloveeclipse self-assigned this Jan 26, 2024
@laeubi
Copy link
Contributor

laeubi commented Jan 26, 2024

Highly likely result of compiler fix eclipse-jdt/eclipse.jdt.core#1906.

Yes, it is. All class changes are valid, i will touch related bundles now.

Tycho uses a (quick) build of the aggregator to catch issues early, maybe JDT can use similar to be aware of such unanticipated changes when compiler is fixed, but its just an idea, total runtime is about 17 minutes.

@iloveeclipse
Copy link
Member Author

I will not start new build now, we will see tomorrow on regular build if it works.

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Jan 26, 2024

maybe JDT can use similar to be aware of such unanticipated changes when compiler is fixed, but its just an idea, total runtime is about 17 minutes.

I've created eclipse-jdt/eclipse.jdt.core#1917. @laeubi : if you know what to do, please push a PR.

@iloveeclipse
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants