Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to Maven central #1882

Closed
Tracked by #1814
elsazac opened this issue Mar 8, 2024 · 12 comments
Closed
Tracked by #1814

Publish to Maven central #1882

elsazac opened this issue Mar 8, 2024 · 12 comments
Labels
task release activities

Comments

@elsazac
Copy link
Member

elsazac commented Mar 8, 2024

No description provided.

@elsazac elsazac mentioned this issue Mar 8, 2024
10 tasks
@elsazac
Copy link
Member Author

elsazac commented Mar 8, 2024

@MohananRahul
when the final release artefacts are created, could you update it here with details ?

@MohananRahul
Copy link
Contributor

    Eclipse downloads:
https://download.eclipse.org/eclipse/downloads/drops4/R-4.31-202402290520/

New and Noteworthy:
https://www.eclipse.org/eclipse/news/4.31/

Update existing (non-production) installs:
https://download.eclipse.org/eclipse/updates/4.31/

Specific repository good for building against:
https://download.eclipse.org/eclipse/updates/4.31/R-4.31-202402290520/

Equinox specific downloads:
https://download.eclipse.org/equinox/drops/R-4.31-202402290520/

@merks
Copy link
Contributor

merks commented Mar 8, 2024

@elsazac @MohananRahul

I made the changes and restarted your release build to start this build:

https://ci.eclipse.org/releng/job/CBIaggregator/894

The job completed and the validation is running now:

https://ci.eclipse.org/releng/view/Publish%20to%20Maven/

So I think this is on track now.

@merks
Copy link
Contributor

merks commented Mar 8, 2024

😱

I see that validation failed now.

14:49:03 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.6.0:get (default-cli) on project standalone-pom: Couldn't download artifact: org.eclipse.aether.resolution.DependencyResolutionException: The following artifacts could not be resolved: xml-apis:xml-apis-ext:jar:1.0.0.v20230923-0644 (absent): Could not find artifact xml-apis:xml-apis-ext:jar:1.0.0.v20230923-0644 in eclipse.maven.central.mirror (https://repo.eclipse.org/content/repositories/maven_central/) -> [Help 1]

I will need to investigate and that might take significant time.

In the meantime, I will kick off a snapshot job to see if that fails differently.

@merks
Copy link
Contributor

merks commented Mar 8, 2024

FYI, I expect this mapping to have mapped it properly

image

like is the case in this preview analysis:

image

Investigating...

@elsazac
Copy link
Member Author

elsazac commented Mar 8, 2024

@merks - in your job 894: https://ci.eclipse.org/releng/job/CBIaggregator/894/console

I can see the problematic bundle being mirrored correctly:

19:08:57 - mirrored artifact osgi.bundle,org.eclipse.orbit.xml-apis-ext,1.0.0.v20230923-0644

so just wondering why the validator failed?

@merks
Copy link
Contributor

merks commented Mar 8, 2024

Oh dear, here is the problem. I see this locally test:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.8:get (default-cli) on project standalone-pom: Couldn't download artifact: Missing:
[ERROR] ----------
[ERROR] 1) xml-apis:xml-apis-ext:jar:1.0.0.v20230923-0644
[ERROR]
[ERROR]   Try downloading the file manually from the project website.
[ERROR]
[ERROR]   Then, install it using the command:
[ERROR]       mvn install:install-file -DgroupId=xml-apis -DartifactId=xml-apis-ext -Dversion=1.0.0.v20230923-0644 -Dpackaging=jar -Dfile=/path/to/file
[ERROR]
[ERROR]   Alternatively, if you host your own repository you can deploy the file there:
[ERROR]       mvn deploy:deploy-file -DgroupId=xml-apis -DartifactId=xml-apis-ext -Dversion=1.0.0.v20230923-0644 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
[ERROR]
[ERROR]   Path to dependency:
[ERROR]         1) org.apache.maven.plugins:maven-downloader-plugin:jar:1.0
[ERROR]         2) org.eclipse.platform:org.eclipse.e4.ui.swt.gtk:jar:1.2.100
[ERROR]         3) org.eclipse.platform:org.eclipse.e4.ui.css.swt.theme:jar:0.14.200
[ERROR]         4) xml-apis:xml-apis-ext:jar:1.0.0.v20230923-0644
[ERROR]
[ERROR] ----------
[ERROR] 1 required artifact is missing.
[ERROR]
[ERROR] for artifact:
[ERROR]   org.apache.maven.plugins:maven-downloader-plugin:jar:1.0
[ERROR]
[ERROR] from the specified remote repositories:
[ERROR]   central (https://repo.maven.apache.org/maven2, releases=true, snapshots=false),
[ERROR]   temp (file:/D:/Users/merks/build/temp/repo-896, releases=true, snapshots=true)
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

We're wanting to publish this artifact, which is 2) above:

image

But that artifact already exits at maven central, so the dependency checker appears to use that one and it has a dependency on org.eclipse.platform:org.eclipse.e4.ui.css.swt.theme:jar:0.14.200 rather than org.eclipse.platform:org.eclipse.e4.ui.css.swt.theme:jar:0.14.300`.

But that version is broken at Maven central:

image

Our new version of that is correct though:

image

It maps the dependency to this existing thing at Maven Central:

https://repo1.maven.org/maven2/xml-apis/xml-apis-ext/1.3.04/

I'm not sure how best to repair this. We can't re-publish the artifact.

The only thing I can think of is to map org.eclipse.platform:org.eclipse.e4.ui.swt.gtk:jar:1.2.100 to org.eclipse.platform:org.eclipse.e4.ui.swt.gtk:jar:1.2.101, i.e., to a new slightly higher different version such that it can be published and is used for dependency resolution testing. It feels very hacky, but I can think of no other way, other than to skip validation entirely.

@elsazac @MohananRahul @laeubi

Do you have an opinion on this?

@merks
Copy link
Contributor

merks commented Mar 8, 2024

I think this would work

image

Nothing else being published actually depends on org.eclipse.e4.ui.swt.gtk...

I'll give folks a bit of time and then later today or tomorrow morning I will apply this workaround.

@merks
Copy link
Contributor

merks commented Mar 8, 2024

Next failure:

[ERROR]   Path to dependency:
[ERROR]         1) org.apache.maven.plugins:maven-downloader-plugin:jar:1.0
[ERROR]         2) org.eclipse.platform:org.eclipse.swt.tools.base:jar:3.107.500
[ERROR]         3) org.eclipse.platform:org.eclipse.ui:jar:3.205.0
[ERROR]         4) org.eclipse.platform:org.eclipse.ui.workbench:jar:3.131.0
[ERROR]         5) org.eclipse.platform:org.eclipse.e4.ui.css.swt.theme:jar:0.14.200
[ERROR]         6) xml-apis:xml-apis-ext:jar:1.0.0.v20230923-0644

Similar problem. This exists

https://repo1.maven.org/maven2/org/eclipse/platform/org.eclipse.swt.tools.base/3.107.500/org.eclipse.swt.tools.base-3.107.500.pom

has an old dependency dragging in the old broken chain:

image

I've applied the analogous solution. The validation failure was very close to the end so hopefully this is the last one.

@merks
Copy link
Contributor

merks commented Mar 8, 2024

The builds were successful.

@elsazac
Copy link
Member Author

elsazac commented Mar 9, 2024

@merks I could see the repos in staging view and I will be it closing soon.

Thanks for your work on this.

merks added a commit to merks/eclipse.platform.swt that referenced this issue Mar 9, 2024
Force a new version so that publishing to Maven Central can update the
version without specialized remapping rules.

eclipse-platform/eclipse.platform.releng.aggregator#1882
merks added a commit to merks/eclipse.platform.ui that referenced this issue Mar 9, 2024
Force a new version so that publishing to Maven Central can update the
version without specialized remapping rules.

eclipse-platform/eclipse.platform.releng.aggregator#1882
merks added a commit to merks/eclipse.platform.swt that referenced this issue Mar 9, 2024
Force a new version so that publishing to Maven Central can update the
version without specialized remapping rules.

eclipse-platform/eclipse.platform.releng.aggregator#1882
merks added a commit to eclipse-platform/eclipse.platform.swt that referenced this issue Mar 9, 2024
Force a new version so that publishing to Maven Central can update the
version without specialized remapping rules.

eclipse-platform/eclipse.platform.releng.aggregator#1882
merks added a commit to eclipse-platform/eclipse.platform.ui that referenced this issue Mar 9, 2024
Force a new version so that publishing to Maven Central can update the
version without specialized remapping rules.

eclipse-platform/eclipse.platform.releng.aggregator#1882
@merks
Copy link
Contributor

merks commented Mar 9, 2024

FYI, with the above changes we can, for the next release cycle, remove the mapping rules that were added.

@elsazac elsazac closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task release activities
Projects
None yet
Development

No branches or pull requests

4 participants