New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add javax.inject/annotation provided by Jakarta from Maven-Central and include all sources in Eclipse SDK repo #1057
Add javax.inject/annotation provided by Jakarta from Maven-Central and include all sources in Eclipse SDK repo #1057
Conversation
403ebcd
to
a62df36
Compare
a62df36
to
c4a600e
Compare
For now I changed this PR to only add the jakarta-bundles because of eclipse-platform/eclipse.platform.common#145 (comment). The removal of the javax-bundles will happen in a follow up, after a nightly build. |
Use the javax namespace bundles provided by Jakarta. Part of eclipse-platform#1056
c4a600e
to
1f5b08f
Compare
Comparing the produced
Therefore I merge this so that the mentioned bundles are available in the repo tomorrow and I can continue the migration. |
Btw. @akurtakov, @merks, @laeubi with configuring the In the last discussion about removing them, then main argument to leave them in was that this way it is ensured that the sources are included into the p2-repo and therefore available without any further magic (like m2e). |
Yes the force qualifier updates changes are a pain in the neck. The cbi aggregator also aggregates corresponding source bundles for every bundle otherwise aggregated so this would continue to work well for SimRel. |
If the bundle is from maven (central) and m2e is available the sources should even be downloaded if not in the update-site. |
Use the javax namespace bundles provided by Jakarta.
Remove all javax bundles provided by Orbit.
Remove the unused javax.xml bundle, the modern JREs provide the contained packages by default.
Part of #1056
Additionally configure the
tycho-p2-repository-plugin
to include all sources. This allows to remove the javax-bundles from containing features (see eclipse-platform/eclipse.platform.ui#745) and at the same time to keep the main artifacts (which are pulled in as transitive dependencies) plus their sources in the created p2-repo for the Eclipse SDK.