Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config tycho-compiler-plugin to use project settings #1661

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

akurtakov
Copy link
Member

eclipse-platform/eclipse.platform#973 identified that IDE builds and maven builds produce different bytecode due to ignoring project settings which shouldn't be the case

@iloveeclipse
Copy link
Member

@akurtakov : if you want continue, it would be a good moment. I'm pushing "touch bundles" PR's right now...

@akurtakov
Copy link
Member Author

I'm looking into it but I'm not sure I can make it build in time. Please let me know when you're going to start I-build here - just in case.

@iloveeclipse
Copy link
Member

Please let me know when you're going to start I-build here - just in case.

Sure, but it will take some time, there will be bundles with not changed manifests etc. There is always something...

@laeubi
Copy link
Contributor

laeubi commented Dec 14, 2023

@akurtakov maybe we should simply remove "fail on warnings" from all projects and use quality gate instead.

@iloveeclipse
Copy link
Member

maybe we should simply remove "fail on warnings" from all projects and use quality gate instead.

Where is that specified? Maven or jenkins file or project preferences?
if you can, propose a PR & if Alex would not make it in time, we can merge that additionally, and later fix every project that insists to see errors on warnings.

@laeubi
Copy link
Contributor

laeubi commented Dec 14, 2023

Where is that specified? Maven or jenkins file or project preferences?

sometimes on Jenkinsfile sometimes in poms as far as I know.

eclipse-platform/eclipse.platform#973 identified that IDE builds and maven builds produce different bytecode due to ignoring project settings which shouldn't be the case
@akurtakov
Copy link
Member Author

OK, build succeeded and I'm pushing this one.

@akurtakov akurtakov merged commit cf74f8d into eclipse-platform:master Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants