Skip to content

Commit

Permalink
Allow Converter to fetch jdt's dot.xml dtd
Browse files Browse the repository at this point in the history
As dot.xml files are generated inside EF infra, stored there and
converter run there - there should be no security concern over fetching
a dtd (coming from EF too).
  • Loading branch information
akurtakov committed Apr 3, 2024
1 parent bd8c70a commit 3e344c1
Showing 1 changed file with 4 additions and 2 deletions.
Expand Up @@ -9,7 +9,6 @@

package org.eclipse.releng.build.tools.convert.ant;

import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.FileFilter;
import java.io.IOException;
Expand Down Expand Up @@ -208,7 +207,10 @@ public void parse2() throws ParserConfigurationException {
factory.setValidating(validation);
factory.setIgnoringElementContentWhitespace(true);
final DocumentBuilder builder = factory.newDocumentBuilder();
builder.setEntityResolver((publicId, systemId) -> new InputSource(new ByteArrayInputStream(new byte[0])));
// Commented due to
// https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/issues/1943
// builder.setEntityResolver((publicId, systemId) -> new InputSource(new
// ByteArrayInputStream(new byte[0])));

final String inputSourceOption = options.get(INPUT_SOURCE);
if (options.get(RECURSIVE) != null) {
Expand Down

0 comments on commit 3e344c1

Please sign in to comment.