New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor popup disappears too soon #177
Comments
I confirm it only happens with Wayland: if you start Eclipse with |
@joel-majano Would you please look into this one? |
I'm able to reproduce this in my environment. I'll begin investigating. |
@joel-majano From my experiments i found that you have more chances to succeed to use the pop-up if you control click from near the bottom of the type in the editor |
Still an issue with gnome 23.0 ; this issue is not a recent regression, as it exists since eclipse supports wayland. Not sure if it is related, but javadoc popups also disappears too soon (F2 key to trigger focus works, but moving cursor from symbol to popup to focus it is highly inconsistent). These two issues are the last ones that make me still run eclipse with |
Here is two screen capture, same gnome 43.0 session (wayland). Same workspace, same eclipse instance, x11 started with
I try to search in jdt ui or eclipse text editor where swt components are managed, to see how cursor movement is expected to work so that it does not close popup when mouse flies hover the empty gap between hyperlink and popup (timer, transparent widget, ...). As eclipse is highly modularized, I do not find it. May someone help me to locate this code, so I try to understand the issue ? eclipse-x11.webmeclipse-wayland.webm |
This is still an issue with eclipse 2023.03 / Fedora 37 / Gnome 43.4. I do not find any workaround to make it working with wayland : popup too frequently closes before cursor can reach it. |
I think I find a workaround. With The only way I find to make it permanent in a gnome-shell environment is to switch gnome-shell settings.
This workaround makes eclipse in a Fedora 38 / Eclipse 4.27 / wayland environment usable with the I hope this workaround may help to fix this issue. If anyone knows how to turn off animation only for eclipse and not all the gnome desktop applications, I would be grateful to hear it. |
I'm late on this train but it is also the main annoyance with Wayland in my opinion.
in eg your eclipse installation folder |
Unfortunately this does not work. As I understand it, gtk contextually uses other settings sources when available, so settings.ini is ignored. Seems consistent with this : https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.36/gdk/wayland/gdkscreen-wayland.c#L717 ; gtk settings uses xdg-portal (can be disabled by GTK_USE_PORTAL) and dbus (I don't find a way to disable it ; DBUS_SESSION_BUS_ADDRESS= does not seem to be enough to isolate gtk from dbus) with a higher priority. Interested if anyone has a clue to force gtk to use settings.ini. |
After some testing, I think that animations enabled/disabled has no effect on the issue. I think that I think I find the code that is responsible for displaying this component : |
Unexpected closing event for popup is triggered by From my investigation, wrong coordinates are extracted here :
|
In
|
Do you think this is a valid and safe and simple enough workaround to submit a PR for it? |
Sadly, not a workaround. I perform further testing, and « wrong » position varies, and x value becomes positive if both the label is long enough (for example ScheduledExecutor) and mouse moves on the right side of the label. For the moment I try to understand if this « buggy » position makes sense to check :
(learning both SWT and GTK, so it is kind of uneasy). |
Depending on the window currently focused the coordinates returned may be wrong (sometimes even negative). This happens mainly with popup windows. Fixes eclipse-platform#177
Depending on the window currently focused the coordinates returned may be wrong (sometimes even negative). This happens mainly with popup windows. Fixes eclipse-platform#177
Depending on the window currently focused the coordinates returned may be wrong (sometimes even negative). This happens mainly with popup windows. Fixes eclipse-platform#177
Depending on the window currently focused the coordinates returned may be wrong (sometimes even negative). This happens mainly with popup windows. Fixes eclipse-platform#177
Experiencing the same issue on Arch Linux, KDE Plasma and Eclipse 2024-03 |
I seem to understand that it also happens in Gnome, though less frequently |
Still an issue on Fedora 39 / Gnome shell / Wayland / Eclipse 2024-03. Same buggy behavior observed. Still difficult to use ctrl+hover menu (Open declaration, Open implementation, ...) as shown in previous video. Fedora 39 / Gnome shell / Wayland / Eclipse 2024-03 GDK_BACKEND=x11 is OK. I just see that there's some work on the issue and a PR #960 opened. |
I give a try to the PR #960 and it fixes the issue. Hoping that it may be merged for the next Eclipse release. |
Depending on the window currently focused the coordinates returned may be wrong (sometimes even negative). This happens mainly with popup windows. Fixes eclipse-platform#177
Depending on the window currently focused the coordinates returned may be wrong (sometimes even negative). This happens mainly with popup windows. Fixes eclipse-platform#177
Depending on the window currently focused the coordinates returned may be wrong (sometimes even negative). This happens mainly with popup windows. Fixes #177
@akurtakov thanks for fixing this! |
It should be in the latest I-build. |
I think this issue might be related to Wayland (in Linux) because I've just started using the Wayland session in Gnome 42 and I've never experienced this problem before: when I Ctrl+click on a type in the editor and the popup for "Open declaration"/"Open implementation" appears, it becomes nearly impossible to select "Open implementation" (the second item) because the popup disappears (most of the time) when you move the mouse to select the menu. And this happens in Fedora, Arch and Ubuntu (latest versions, Gnome 42, all with Wayland session).
The version of Eclipse is 2022-03 (4.23.0) but it also happens in 2022-06 M3
I had reported on JDT UI eclipse-jdt/eclipse.jdt.ui#72 but they told me this is the right place.
The text was updated successfully, but these errors were encountered: