Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table remains visible though setVisible(false) was called #223

Open
niraj-modi opened this issue Jun 23, 2022 · 10 comments · Fixed by #224, #231, #235, #238 or #239
Open

Table remains visible though setVisible(false) was called #223

niraj-modi opened this issue Jun 23, 2022 · 10 comments · Fixed by #224, #231, #235, #238 or #239
Assignees
@niraj-modi
Labels
bug Something isn't working Windows Happens on Windows OS

Comments

@niraj-modi
Copy link
Member

niraj-modi commented Jun 23, 2022 •
edited

Describe the bug
Moved from bugzilla: Bug 578833 - [Win32] Table remains visible though setVisible(false) was called

To Reproduce
Refer snippets in below attachment:
https://bugs.eclipse.org/bugs/attachment.cgi?id=288075
https://bugs.eclipse.org/bugs/attachment.cgi?id=280361

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
https://bugs.eclipse.org/bugs/attachment.cgi?id=288076

Environment:

  1. Select the platform(s) on which the behavior is seen:
    • All OS
    • Windows
    • Linux
    • macOS

  1. Additional OS info (e.g. OS version, Linux Desktop, etc)

  2. JRE/JDK version

Version since
Eclipse or SWT version since when the behavior is seen [e.g. 4.23]

Workaround (or) Additional context
Known bug in native api call:
https://docs.microsoft.com/en-us/windows/win32/gdi/wm-setredraw
@niraj-modi niraj-modi added bug Something isn't working Windows Happens on Windows OS labels Jun 23, 2022
@niraj-modi
Copy link
Member Author

Solution is to explicitly identify such case where the table style differs from the table's 'visible' state and then restore the table's visibility state. Will share a PR shortly.

niraj-modi added a commit to niraj-modi/eclipse.platform.swt that referenced this issue Jun 23, 2022
@niraj-modi
Table remains visible though setVisible(false) was called fixes eclip…
924b602 
…se-platform#223

Change-Id: Ie6ea38db33f395efbba13d2451584fed84bfe395
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
@niraj-modi niraj-modi mentioned this issue Jun 23, 2022
Merged
niraj-modi added a commit to niraj-modi/eclipse.platform.swt that referenced this issue Jun 27, 2022
@niraj-modi
Table remains visible though setVisible(false) was called
dd81454 
- Fixes eclipse-platform#223

Change-Id: I0c65624752971550482dcb1d0ed8f543cc12807b
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
niraj-modi added a commit to niraj-modi/eclipse.platform.swt that referenced this issue Jun 27, 2022
@niraj-modi
Table remains visible though setVisible(false) was called
bbd835d 
- Fixes eclipse-platform#223

Change-Id: I1b7b6841a9d7170c8f790b90b67d8cc9428e3418
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
niraj-modi added a commit to niraj-modi/eclipse.platform.swt that referenced this issue Jun 27, 2022
@niraj-modi
Table remains visible though setVisible(false) was called
d2d3b39 
- Fixes eclipse-platform#223

Change-Id: I410cb1b82c105f124bea13994b7b771a510d8bef
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
niraj-modi added a commit that referenced this issue Jun 27, 2022
@niraj-modi
Table remains visible though setVisible(false) was called
2996f2f 
- Fixes #223

Change-Id: I410cb1b82c105f124bea13994b7b771a510d8bef
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
@niraj-modi niraj-modi self-assigned this Jun 27, 2022
@niraj-modi niraj-modi added this to the 4.25 M1 milestone Jun 27, 2022
@iloveeclipse
Copy link
Member

iloveeclipse commented Jun 28, 2022 •
edited

@niraj-modi : this broke some tables on Windows.
Git History is empty, "Ctrl+3" is empty.

This must be fixed before M1, Eclipse is unusable since this change.

@iloveeclipse iloveeclipse reopened this Jun 28, 2022
@niraj-modi niraj-modi linked a pull request Jun 29, 2022 that will close this issue
Part2: Table remains visible though setVisible(false) was called #231
Merged
@niraj-modi niraj-modi mentioned this issue Jun 29, 2022
Merged
@iloveeclipse iloveeclipse mentioned this issue Jun 29, 2022
Closed
niraj-modi added a commit to niraj-modi/eclipse.platform.swt that referenced this issue Jun 29, 2022
@niraj-modi
Table remains visible though setVisible(false) was called
38477cf 
- fixes eclipse-platform#223

Change-Id: If2da1df46b4b6328c537ce34585c585e86136452
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
@niraj-modi niraj-modi mentioned this issue Jun 29, 2022
Merged
@niraj-modi
Copy link
Member Author

Reopening to handle:
eclipse-jdt/eclipse.jdt.ui#127 (comment)

@niraj-modi niraj-modi reopened this Jun 29, 2022
niraj-modi added a commit that referenced this issue Jun 29, 2022
@niraj-modi
Table remains visible though setVisible(false) was called
2b1d0c9 
- fixes #223

Change-Id: If2da1df46b4b6328c537ce34585c585e86136452
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
@niraj-modi
Copy link
Member Author

Verified the fix in Build id: I20220629-1800

@niraj-modi niraj-modi added the fix verified The implemented fix has been verified with an I-build label Jun 30, 2022
@vogella
Copy link
Contributor

vogella commented Jun 30, 2022

History view seems to be still sometimes empty with this change, I have to re-select the repo to show content. Not reproducable though, so no need for you to do anything, but maybe you want to watch out for this behavior.

@vogella vogella reopened this Jun 30, 2022
@vogella
Copy link
Contributor

vogella commented Jun 30, 2022

Found the reproducer:

Open History view with some content

image

Resize the view

image

-> View is empty

Eclipse SDK
Version: 2022-06 (4.25)
Build id: I20220629-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 17.0.2+8
Java version: 17.0.2

@vogella
Copy link
Contributor

vogella commented Jun 30, 2022

Also code completion popup is currently empty once it is triggered, you need to retrigger it to show its content.

@niraj-modi
Copy link
Member Author

Also code completion popup is currently empty once it is triggered, you need to retrigger it to show its content.

Will release a fix for this shortly.

@niraj-modi niraj-modi mentioned this issue Jul 1, 2022
Merged
This was linked to pull requests Jul 1, 2022
Part4: Table remains visible though setVisible(false) was called #238
Merged
Revert: Table remains visible though setVisible(false) was called #239
Merged
@niraj-modi niraj-modi removed the fix verified The implemented fix has been verified with an I-build label Jul 1, 2022
@niraj-modi niraj-modi removed this from the 4.25 M1 milestone Jul 1, 2022
@niraj-modi
Copy link
Member Author

niraj-modi commented Jul 1, 2022 •
edited

Attempted fixes caused regression in Eclipse views, hence decided to revert the complete fix via #239

@niraj-modi niraj-modi reopened this Jul 1, 2022
@tmssngr
Copy link
Contributor

tmssngr commented Feb 23, 2024

It looks like the problem is triggered in Table.setDeferResize(true) when invoking OS.IsWindowVisible (handle). Why is this call used and not, e.g. isVisible()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niraj-modi niraj-modi

Labels
bug Something isn't working Windows Happens on Windows OS
Projects
None yet
Milestone
No milestone
4 participants
@vogella @iloveeclipse @tmssngr @niraj-modi