Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[win32][GTK] Remove incomplete win32-gtk implementation #425

Closed
SyntevoAlex opened this issue Oct 8, 2022 · 4 comments · Fixed by eclipse-platform/eclipse.platform.swt.binaries#17 or #426
Assignees
Labels
Windows Happens on Windows OS

Comments

@SyntevoAlex
Copy link
Member

Win32-GTK implementation was developed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=488431

According to my understanding, it was never finished, and nobody uses it. At the same time, its presence routinely confuses me: when I change some build settings for win32, I stumble upon a copy of make_win32.mak for win32-gtk, and wonder if I need to change it or not.

As per discussion in Bug 488431, the implementation was never finished, and the bug is closed as WONTFIX.
Therefore, it would be best to remove it from SWT entirely.

@SyntevoAlex SyntevoAlex added the Windows Happens on Windows OS label Oct 8, 2022
@SyntevoAlex SyntevoAlex self-assigned this Oct 8, 2022
SyntevoAlex added a commit to syntevo/eclipse.platform.swt that referenced this issue Oct 8, 2022
… implementation

Win32-GTK implementation was developed in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=488431

According to my understanding, it was never finished, and nobody uses
it. At the same time, its presence routinely confuses me: when I change
some build settings for win32, I stumble upon a copy of `make_win32.mak`
 for win32-gtk, and wonder if I need to change it or not.

As per discussion in Bug 488431, the implementation was never finished,
and the bug is closed as WONTFIX. Therefore, it would be best to remove
it from SWT entirely.

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
SyntevoAlex added a commit to syntevo/eclipse.platform.swt that referenced this issue Oct 8, 2022
… implementation

Win32-GTK implementation was developed in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=488431

According to my understanding, it was never finished, and nobody uses
it. At the same time, its presence routinely confuses me: when I change
some build settings for win32, I stumble upon a copy of `make_win32.mak`
 for win32-gtk, and wonder if I need to change it or not.

As per discussion in Bug 488431, the implementation was never finished,
and the bug is closed as WONTFIX. Therefore, it would be best to remove
it from SWT entirely.

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
@SyntevoAlex
Copy link
Member Author

I prepared pull requests:
eclipse-platform/eclipse.platform.swt.binaries#17
#426

SyntevoAlex added a commit to syntevo/eclipse.platform.swt that referenced this issue Oct 8, 2022
… implementation

Win32-GTK implementation was developed in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=488431

According to my understanding, it was never finished, and nobody uses
it. At the same time, its presence routinely confuses me: when I change
some build settings for win32, I stumble upon a copy of `make_win32.mak`
 for win32-gtk, and wonder if I need to change it or not.

As per discussion in Bug 488431, the implementation was never finished,
and the bug is closed as WONTFIX. Therefore, it would be best to remove
it from SWT entirely.

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
akurtakov pushed a commit that referenced this issue Oct 13, 2022
Win32-GTK implementation was developed in
https://bugs.eclipse.org/bugs/show_bug.cgi?id=488431

According to my understanding, it was never finished, and nobody uses
it. At the same time, its presence routinely confuses me: when I change
some build settings for win32, I stumble upon a copy of `make_win32.mak`
 for win32-gtk, and wonder if I need to change it or not.

As per discussion in Bug 488431, the implementation was never finished,
and the bug is closed as WONTFIX. Therefore, it would be best to remove
it from SWT entirely.

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
@SyntevoAlex
Copy link
Member Author

@akurtakov thanks for your assistance!

@syncingdisks
Copy link

I am currently using broadwayd from GTK3 under Win to expose Eclipse in browser, it was a good (working) experiment (still is, tinkering with GTK4+Vulkan). Too bad this gets obscured in the git repo history, but it is just a personal opinion I guess.

@akurtakov
Copy link
Member

akurtakov commented Nov 2, 2022

I am currently using broadwayd from GTK3 under Win to expose Eclipse in browser, it was a good (working) experiment (still is, tinkering with GTK4+Vulkan). Too bad this gets obscured in the git repo history, but it is just a personal opinion I guess.

Whatever doesn't manage to gain enough interest becomes liability for maitainers as we are not aware of any usage but it still complicates our searches, releng work and etc. People should really engage with upstream community and help maintaining things or it ends like this one.

HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Feb 15, 2024
…in32-gtk implementation"

This reverts commit 695fcb3.
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Feb 23, 2024
…in32-gtk implementation"

This reverts commit 695fcb3.
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Apr 7, 2024
…in32-gtk implementation"

This reverts commit 695fcb3.
HeikoKlare added a commit to swt-initiative31/prototype-gtk that referenced this issue May 27, 2024
…in32-gtk implementation"

This reverts commit 695fcb3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment