[Win32][Dark theme] Button with SWT.ARROW style has light background

[betamaxbandit]

When Eclipse (on Windows) is in Dark Theme (Preferences > General > Appearance > Theme), org.eclipse.swt.widgets.Button widgets with style SWT.ARROW are shown with a light background. Expected to have a dark background.
The screenshot below shows a comparison of how this looks on Ubuntu 20.04 vs Win11_22621:

To Reproduce
From an Eclipse SDK launch a runtime workbench and open the "SWT Controls" view [1].
Choose the Button tab and in Parameters choose SWT.ARROW
Expected: button has a dark background.
Actual: button has a light background.

Environment
Windows - Windows11 22H2 10.0.22621.755 and earlier.
Eclipse SDK Version: 2022-12 (4.26) Build id: I20221113-1800

Workaround (or) Additional context
None.

Originally reported in:
Bug 566269 - [Win32][Dark theme] Check boxes light in the dark theme

[1] "SWT Controls"
eclipse.platform.swt\examples\org.eclipse.swt.examples.views
https://github.com/eclipse-platform/eclipse.platform.swt/blob/master/examples/org.eclipse.swt.examples.views/src/org/eclipse/swt/examples/controls/ControlView.java

[deepika-u]

@SyntevoAlex
Can you please confirm if this is also a windows theming issue, not an SWT bug. If yes can we close it?

[deepika-u]

@SyntevoAlex
Sorry to bother you again, by any chance did you get some time to check on this please? Even if it is expected behavior with current windows theming, should we close it or leave it open and mark it "windows theme" label or something and look at it later when windows implement them.

[SyntevoAlex]

Yes, I plan to look at it, but not sure how soon. My inbox is too full of things needing attention.

[deepika-u]

Hi @SyntevoAlex

Without the patch seeing the buttons like this

With the patch i am seeing the buttons like this

In the same context, does the background for the tabs named Button, Canvas, Color, Combo, CoolBar, DateTime and so on should also be in dark when we are in dark theme? as compared against linux shared image(shared in the starting of the issue #473)

Thanks alot for your quick fix.

[betamaxbandit]

Hi @deepika-u ,

Thanks for testing this. I was going to do that, but haven't got round to it yet. Good to see it working now.

Was your test on Windows 10 or 11?

[SyntevoAlex]

In the same context, does the background for the tabs named Button, Canvas, Color, Combo, CoolBar, DateTime and so on should also be in dark when we are in dark theme?

Please see Bug 566359

[SyntevoAlex]

In master now.

[deepika-u]

Hi @deepika-u ,

Thanks for testing this. I was going to do that, but haven't got round to it yet. Good to see it working now.

Was your test on Windows 10 or 11?

I have tried it on below environment
Eclipse SDK
Version: 2023-06 (4.28)
Build id: I20230426-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Oracle Corporation
Java runtime version: 19.0.1+10-21
Java version: 19.0.1