Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to easily spot which CTabFolder/CTabItem has focus (eg in Workbench) #55

Closed
mickaelistria opened this issue Apr 19, 2022 · 1 comment · Fixed by #183
Closed

Allow to easily spot which CTabFolder/CTabItem has focus (eg in Workbench) #55

mickaelistria opened this issue Apr 19, 2022 · 1 comment · Fixed by #183
Labels
api Adds new API enhancement New feature or request fix verified The implemented fix has been verified with an I-build noteworthy N&N entry
Milestone
4.25 M1

Comments

@mickaelistria
Copy link
Contributor

1 issue that theme have to resolve is that when there are multiple CTabFolders on the same window (eg the workbench), it's not clear which current folder has the focus and which actual tabs has focus. The default CTabFolderRenderer should try to resolve that issue, maybe with some option; by applying some color or border to better identify the current focus in case multiple CTabFolders are shown on the same window.
@mickaelistria mickaelistria mentioned this issue Apr 19, 2022
Closed
@mickaelistria
Copy link
Contributor Author

Here is a proposal of how this would look like (the color would be the one defined in SWT.SELECTION_COLOR_BACKGROUND constant or similar)
ctab-before-after

mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue May 31, 2022
@mickaelistria
More visible highlight of active CTab(Folder) eclipse-platform#55
e39a040 
Adds a thick line under the active tab of each folder; and use the
selection color for the "active with focus".
@mickaelistria mickaelistria linked a pull request May 31, 2022 that will close this issue
More visible highlight of active CTab(Folder) #55 #183
Merged
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue May 31, 2022
@mickaelistria
More visible highlight of active CTab(Folder) eclipse-platform#55
44bed77 
Adds a thick line under the active tab of each folder; and use the
selection color for the "active with focus".
iloveeclipse pushed a commit to iloveeclipse/eclipse.platform.swt that referenced this issue May 31, 2022
@mickaelistria @iloveeclipse
More visible highlight of active CTab(Folder) eclipse-platform#55
3537562 
Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
iloveeclipse pushed a commit to iloveeclipse/eclipse.platform.swt that referenced this issue May 31, 2022
@mickaelistria @iloveeclipse
More visible highlight of active CTab(Folder) eclipse-platform#55
2a1582a 
Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue May 31, 2022
@mickaelistria
More visible highlight of active CTab(Folder) eclipse-platform#55
e6460b4 
Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue May 31, 2022
@mickaelistria
More visible highlight of active CTab(Folder) eclipse-platform#55
d63b240 
Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue May 31, 2022
@mickaelistria
More visible highlight of active CTab(Folder) eclipse-platform#55
9eecbf0 
Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue Jun 1, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab eclipse…
fa3bae2 
…-platform#55

Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue Jun 2, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab eclipse…
1415f62 
…-platform#55

Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue Jun 3, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab eclipse…
c6da6e2 
…-platform#55

Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue Jun 8, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab eclipse…
8f5dc16 
…-platform#55

Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue Jun 9, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab eclipse…
5d41121 
…-platform#55

Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue Jun 9, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab eclipse…
9869eca 
…-platform#55

Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit to mickaelistria/eclipse.platform.swt that referenced this issue Jun 10, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab eclipse…
95f02b6 
…-platform#55

Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
mickaelistria added a commit that referenced this issue Jun 13, 2022
@mickaelistria
CTabFolderRenderer option for visible highlight of active tab #55
56b1a0f 
Adds a thick line on top of the selected tab of each folder; uses the
selection color for the "active with focus".
@akurtakov akurtakov mentioned this issue Jun 13, 2022
Merged
@niraj-modi niraj-modi added this to the 4.25 M1 milestone Jun 14, 2022
@niraj-modi niraj-modi added enhancement New feature or request noteworthy N&N entry api Adds new API labels Jun 14, 2022
@niraj-modi niraj-modi added the fix verified The implemented fix has been verified with an I-build label Jul 7, 2022
@niraj-modi niraj-modi mentioned this issue Jul 15, 2022
Merged
@jukzi jukzi mentioned this issue Aug 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Adds new API enhancement New feature or request fix verified The implemented fix has been verified with an I-build noteworthy N&N entry
Projects
None yet
Milestone
4.25 M1
Development

Successfully merging a pull request may close this issue.

More visible highlight of active CTab(Folder) #55 mickaelistria/eclipse.platform.swt
2 participants
@mickaelistria @niraj-modi