-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Unify make targets for native binaries build #1007
[Build] Unify make targets for native binaries build #1007
Conversation
@@ -113,7 +113,7 @@ swt_awt.res: | |||
swt_wgl.res: | |||
rc $(RCFLAGS) -DSWT_ORG_FILENAME=\"$(WGL_LIB)\" -r -fo swt_wgl.res swt_wgl.rc | |||
|
|||
install: | |||
install: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other platforms the make files look similar and I had the impression that this means when invoking the install
make-target call all
before.
But it looks like this does not work on Windows.
@akurtakov I believe you are also familiar with C and maybe with make? Can you help on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work as you described it. I have no idea why this doesn't happen on Windows. I haven't done anything with native compilers on Windows .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem was that in the build.bat
native-binary built script for windows called the shift
command to strip of the first passed argument and then passed all remaining arguments to the make file:
nmake -f make_win32.mak %1 %2 %3 %4 %5 %6 %7 %8 %9
But since the first argument always had to be x86_64
, but then the value was never read I removed it with this change.
But this had the consequence, that when calling build.bat install clean
the make file make_win32.mak
was called without the first argument, consequently only invoked the clean
target.
7ab5517
to
f7de241
Compare
Remove requirement to specify the arch as first argument for Windows in the build.bat. The first argument always has to be 'x86_64' but the value is then never used. Part of eclipse-platform#513
f7de241
to
f0a8308
Compare
Part of #513