Use smaller row heights on Mac if smallFonts specified #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Phillipus
commented
Feb 20, 2024
Phillipus
commented
- If small fonts are set with -Dorg.eclipse.swt.internal.carbon.smallFonts then use smaller vertical padding
- This maintains backward compatibility
- See discussion at [macOS] some UI elements (e.g. list, tree views) seem to have more space between lines now eclipse.platform.ui#1674
- If small fonts are set with -Dorg.eclipse.swt.internal.carbon.smallFonts then use smaller vertical padding - This maintains backward compatibility - See discussion at eclipse-platform/eclipse.platform.ui#1674
merks
approved these changes
Feb 20, 2024
|
Because of several doubts expressed here, I'll close this one for now. |
|
Thank you for all your efforts and the detailed explanations. |
|
Continued as an alternate (POC) PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.