Revert 1101

[iloveeclipse]

1. Revert "Replace internal SWTEventListener directly with java.util.EventListener"

This reverts commit bd306ac.
Replacing SWTEventListener directly with java.util.EventListener breaks binary compatibility with bundles compiled against any older SWT version.

• See discussion on Replace internal SWTEventListener directly with java.util.EventListener #1101

2. Added filters for SWTEventListener used in SWT API

• See [Build] Enable API checks in CI builds #1011
• See Replace internal SWTEventListener directly with java.util.EventListener #1101

[github-actions]

Test Results

   299 files  ±0     299 suites  ±0   7m 5s ⏱️ +4s
 4 099 tests ±0   4 091 ✅ ±0   8 💤 ±0  0 ❌ ±0 
12 209 runs  ±0  12 134 ✅ ±0  75 💤 ±0  0 ❌ ±0 

Results for commit 8ef2835. ± Comparison against base commit bd306ac.

♻️ This comment has been updated with latest results.

[iloveeclipse]

I do not see warnings on Linux with this patch.
On Windows I see following warnings (mostly unrelated to the problem we have discussed before, in OLE area):

Composite leaks APIs from the superclass Scrollable
Constructor for Variant with non-API parameter type IDispatch
Constructor for Variant with non-API parameter type IUnknown
GCData.ps declared as non-API type PAINTSTRUCT
OleAutomation.getTypeInfoAttributes() has non-API return type TYPEATTR
OleClientSite.appClsid declared as non-API type GUID
OleClientSite.createTempStorage() has non-API return type IStorage
OleClientSite.getClassID(String) has non-API return type GUID
OleClientSite.objDocumentView declared as non-API type IOleDocumentView
OleClientSite.objIOleCommandTarget declared as non-API type IOleCommandTarget
OleClientSite.objIOleInPlaceObject declared as non-API type IOleInPlaceObject
OleClientSite.objIOleObject declared as non-API type IOleObject
OleClientSite.objIUnknown declared as non-API type IUnknown
OleClientSite.objIViewObject2 declared as non-API type IViewObject2
OleClientSite.tempStorage declared as non-API type IStorage
OleControlSite.getLicenseInfo(GUID) has non-API parameter type GUID
OleControlSite.removeEventListener(OleAutomation, GUID, int, OleListener) has non-API parameter type GUID
Variant.getDispatch() has non-API return type IDispatch
Variant.getUnknown() has non-API return type IUnknown

I will add an additional commit on top that would mute these warnings (looking on the code they existed since very beginning), so that we would have zero API warnings on Windows too.

[merks]

I see these errors in my workspace:

Is this expected?

[iloveeclipse]

@merks :

• Are you using latest https://download.eclipse.org/eclipse/downloads/drops4/I20240311-1800/ build?
• most likely you did it, but just in case: please "clean build" the project

I've tried master on Linux/Windows and see no errors.

[merks]

No, restarts and cleans don't help.

[iloveeclipse]

No, restarts and cleans don't help.

• What about your IDE? Are you using latest build with fix for SWT has ~130 API errors showing "no longer an API" markers for API code eclipse-pde/eclipse.pde#1187?
• The baseline is set to 4.31?

[iloveeclipse]

Just tried on Linux with IDE on I20240313-0830 and baseline on https://download.eclipse.org/eclipse/downloads/drops4/R-4.31-202402290520/ , everything is fine.
I've already tested that before pushing with 4.31RC2 Windows build, I don't expect there is any difference.
Will double check on Windows now with 4.31 final.

[merks]

I have this installed:

I have this API baseline:

The API baseline has content from this repository:

The problem won't go away and it seems like a real problem. Are you expecting an API filter to make it go away? Because the change it's complaining about is really a change since the last release:

Should the revert go farther back?

[iloveeclipse]

Are you expecting an API filter to make it go away?

Yes, with this line:

https://github.com/eclipse-platform/eclipse.platform.swt/blob/master/binaries/org.eclipse.swt.win32.win32.x86_64/.settings/.api_filters#L578

Do you have clean workspace, may be .settings or filters deleted by occasion?

[iloveeclipse]

So, running SDK I20240313-0830 from https://download.eclipse.org/eclipse/downloads/drops4/I20240313-0830/ with API baseline set to the extracted final 4.31 SDK zip file downloaded from https://download.eclipse.org/eclipse/downloads/drops4/R-4.31-202402290520/

Note: everything installed manually without Oomph or maven or any other tooling.

I'm looking on clean SWT git state at a98c844 and see no API errors or warnings on org.eclipse.swt.win32.win32.x86_64 project on Windows:

[merks]

Interesting, the link is not there!

But the file exists in the clone:

I'll have to dig deeper tomorrow.

Thanks for your help so far!! 😀

[iloveeclipse]

Just close and reopen project.

[HannesWell]

Thank you Andrey, for helping in reverting the removal and adding the filters!

I will add an additional commit on top that would mute these warnings (looking on the code they existed since very beginning), so that we would have zero API warnings on Windows too.

Thanks for that as well, I as about to do that too.
In order to prevent API-leakages in the future I have created #1110.

Interesting, the link is not there!

This is a bit convoluted. Since the .settings folder from the parent-folder is linked into the fragment projects to share the settings between the fragments, I had to link the .settings/.api_filters again linking it to their real location. Otherwise the workspace didn't saw it :/.
But for me it worked as well.

[merks]

Close/open didn't work either, but deleting the project from the workspace (not the repository) and running the setup tasks to import the project again worked fine. Thank you!