API Filters on Mac #1109
API Filters on Mac #1109
Conversation
| <resource path="Eclipse SWT/emulated/tooltip/org/eclipse/swt/widgets/ToolTip.java" type="org.eclipse.swt.widgets.ToolTip"> | ||
| <filter id="336744520"> | ||
| <message_arguments> | ||
| <message_argument value="@noextend"/> |
There was a problem hiding this comment.
Looks like you are using older IDE build.
Please use https://download.eclipse.org/eclipse/downloads/drops4/I20240311-1800/ for your IDE
There was a problem hiding this comment.
Please use https://download.eclipse.org/eclipse/downloads/drops4/I20240311-1800/ for your IDE
And the baseline should be 4.31 RC2?
There was a problem hiding this comment.
The baseline should be 4.31 RC, but the IDE you are using should be https://download.eclipse.org/eclipse/downloads/drops4/I20240311-1800/ because of eclipse-pde/eclipse.pde#1187
There was a problem hiding this comment.
BTW you can use fresh https://download.eclipse.org/eclipse/downloads/drops4/I20240313-0830/ if you like.
There was a problem hiding this comment.
New one force pushed. This time there were no API errors, only warnings.
|
Thanks @Phillipus for helping on this one! Also did you know that you can easily check the API for other platforms. Just open the fragment for the corresponding platform+arch in your workspace and set the environment of your active target and the baseline target: After a clean+full-build you should get the issues of that platform+arch. @Phillipus it would be great if you could confirm all I have done is right and there are no more API issues for the mac fragments. |
|
@iloveeclipse and @Phillipus do you have a preference between this PR and #1111? It would be great to have the API issues fixed in Mac to be able to complete #1110. |
|
I had no time today, may be tomorrow I can look. |
@HannesWell I'm by no means knowledgable on this API stuff. I only put this PR here as a means to upload the filter file as instructed by @iloveeclipse I think it would be better to go with #1111 as it's from someone who knows what they're doing. ;-) |
That would be great.
Thanks for the flowers. :) |
Sure, but my problem is how? What version IDE do I need and what target to set? |
|
@HannesWell Actually I figured it out. I downloaded the latest I-build to use as IDE and set the API baseline to a separat 4.31 download. I merged your PR into SWT and....absolutely zero API errors or warnings. :-) |
Perfect, thank you! |
|
Shall we close this one, I think it's not needed now? |
Lets give Andrey some more time to review and add his preference. We can still close this tomorrow :) |
Now that #1111 is submitted, lets close this one. |
API filters