Fix Maven launch config to build SWT binaries #1167
Conversation
fedejeanne
force-pushed
the
bugs/build_swt_maven_launch_broken
branch
from
0b04a03
to
4f042a1
Compare
fedejeanne
changed the title
There was a problem hiding this comment.
Thank you @fedejeanne for this fix.
I have a few suggestions below but none of them are blockers.
bundles/org.eclipse.swt/Build-SWT-native-binaries-for-running-platform.launch
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Build-SWT-native-binaries-for-running-platform.launch
Outdated
Show resolved
Hide resolved
| * On the Targets tab check the build_libraries target (it should be the only one check for just the natives). | ||
| * On the JRE tab select "Run in the same JRE as the workspace" | ||
| * In Eclipse, open the _Run Configurations_ dialog: | ||
| * Run the *Maven* launch configuration called `Build-SWT-native-binaries-for-running-platform` |
There was a problem hiding this comment.
Since this works for all platform I think it would be best to add this either to the general Readme.md in this project or to the CONTRIBUTING.md in the repo root. The reference to it could then also be removed from the Readme.linux.md.
|
Thanks @fedejeanne for the update, it looks good. |
|
@HannesWell I was testing the run configuration in Linux and Mac at home and couldn't make the time to merge yet. I'll squash and merge today and leave the documentation for a follow up 🙂 |
fedejeanne
force-pushed
the
bugs/build_swt_maven_launch_broken
branch
from
5c58eb5
to
0d5c6f3
Compare
- Change base directory of launch config - Activate the option "Refresh" in launch config Co-authored-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
fedejeanne
force-pushed
the
bugs/build_swt_maven_launch_broken
branch
from
0d5c6f3
to
2ca9f2b
Compare
The path was broken since the projects got moved:
But now the path can found:
Also refresh the workspace after running:
Adapt the documentation accordingly.