FileDialog & DirectoryDialog hang after closing them with opened menu #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gtk_file_chooser_native_new handle()` should be dereferenced after use as proposed in https://docs.gtk.org/gtk3/class.FileChooserNative.html. Otherwise `gtk_native_dialog_run()` seem to continue to run (probably because the opened menu still references the dialog), with the effect that: `the recursive main loop gives the effect of a modal dialog (it prevents the user from interacting with other windows in the same window group while the dialog is run)`. See https://docs.gtk.org/gtk3/method.NativeDialog.run.html Fixes eclipse-platform#1062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gtk_file_chooser_native_new handle()should be dereferenced after use as proposed in https://docs.gtk.org/gtk3/class.FileChooserNative.html.Otherwise
gtk_native_dialog_run()seem to continue to run (probably because the opened menu still references the dialog), with the effect that:the recursive main loop gives the effect of a modal dialog (it prevents the user from interacting with other windows in the same window group while the dialog is run).See https://docs.gtk.org/gtk3/method.NativeDialog.run.html
Fixes #1062