SWT Javadoc bash changes for 4.32 #1246
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging changes to documentation is totally allowed during RC phases, as it was mentioend in the RC1 reminder email. |
niraj-modi
approved these changes
May 22, 2024
+1, Approved the Javadoc changes, to be merged in RC2 only. |
|
Reran it today and these are the only changes. Eclipse SDK @niraj-modi : you may please go ahead with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245
@niraj-modi
Can you please review the above changes.
Tried it on below build. Please dont merge this change since we are still in RC1
I'll be rerunning the same once more post RC1 release then only we'll merge it.