[Win32] Restore historical FileDialog behavior #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miration to COM API in Bug 571571 resulted in unexpected changes in behavior. This patch restores original behavior. * Allow non-existent file names in SWT.OPEN dialog (Bug 579359). * Let the system remember last used directory and override FileDialog.setFilterPath (Bug 577773 and Issue #95). This change reverts the fix for Bug 577190 and Bug 578415.
niraj-modi
approved these changes
May 13, 2022
There was a problem hiding this comment.
This patch works and it effectively reopens bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=577190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miration to COM API in Bug 571571 resulted in unexpected changes in behavior. This patch restores original behavior.
Allow non-existent file names in SWT.OPEN dialog (Bug 579359).
Let the system remember last used directory and override FileDialog.setFilterPath (Bug 577773 and FileDialog does not remember previous directory #95).
This change reverts the fix for Bug 577190 and Bug 578415.
@niraj-modi please see my comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=577190#c17