#21 [win32] HDC leak in Image.createGdipImage() #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression from recent Bug 493455, where this line was lost during refactoring: device.internal_dispose_GC(hDC, null) Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
|
@niraj-modi This is a serious regression, I recommend merging despite freeze period. |
SyntevoAlex
force-pushed
the
z_alexandr.miloslavskiy/#0501_SWT_Issue0021_HdcLeak_ImageCreateGdipImage
branch
from
191dce8
to
6476232
Compare
iloveeclipse
approved these changes
Apr 6, 2022
iloveeclipse
reviewed
Apr 6, 2022
| gc.dispose(); | ||
|
|
||
| ImageData imageData = image.getImageData(); | ||
| imageData.transparentPixel = transparent.handle; |
There was a problem hiding this comment.
@SyntevoAlex : on Linux, I see now compiler error: Type mismatch: cannot convert from GdkRGBA to int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexandr Miloslavskiy alexandr.miloslavskiy@syntevo.com