#6 [win32] Keyboard shortcuts for radio buttons don't work anymore #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… work anymore Signed-off-by: Rolf Theunissen <rolf.theunissen@gmail.com>
niraj-modi
approved these changes
Apr 6, 2022
iloveeclipse
reviewed
Apr 6, 2022
| @@ -425,6 +428,48 @@ public void test_setTextLjava_lang_String() { | |||
| button.setText(""); | |||
| } | |||
|
|
|||
| @Test | |||
| public void test_traverseCheckButton() { | |||
There was a problem hiding this comment.
This test fails on Linux.
https://download.eclipse.org/eclipse/downloads/drops4/I20220406-0600/testresults/html/org.eclipse.swt.tests_ep424I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html
Test_org_eclipse_swt_widgets_Button | test_traverseCheckButton | Failure | N/A
java.lang.AssertionErrorat org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Button.test_traverseCheckButton(Test_org_eclipse_swt_widgets_Button.java:448)
There was a problem hiding this comment.
@niraj-modi Did you check the build results before merging?
I was not able to check them because build results were removed already, probably as result of the merge. I wonder if the test consistently fails or if it is flacky.
There was a problem hiding this comment.
I've tried it on Linux locally, that was failing for me two times in the row.
iloveeclipse
reviewed
Apr 6, 2022
| @@ -425,6 +428,48 @@ public void test_setTextLjava_lang_String() { | |||
| button.setText(""); | |||
| } | |||
|
|
|||
| @Test | |||
| public void test_traverseCheckButton() { | |||
There was a problem hiding this comment.
This test fails on Linux.
https://download.eclipse.org/eclipse/downloads/drops4/I20220406-0600/testresults/html/org.eclipse.swt.tests_ep424I-unit-cen64-gtk3-java11_linux.gtk.x86_64_11.html
Test_org_eclipse_swt_widgets_Button | test_traverseCheckButton | Failure | N/A
java.lang.AssertionErrorat org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Button.test_traverseCheckButton(Test_org_eclipse_swt_widgets_Button.java:448)
niraj-modi
pushed a commit
to niraj-modi/eclipse.platform.swt
that referenced
this pull request
Apr 7, 2022
… work anymore (eclipse-platform#24) Change-Id: I09f81bc5041bb1aa61fb7b62300a772aa6853abf Signed-off-by: Rolf Theunissen <rolf.theunissen@gmail.com>
niraj-modi
pushed a commit
that referenced
this pull request
Apr 7, 2022
Change-Id: I09f81bc5041bb1aa61fb7b62300a772aa6853abf Signed-off-by: Rolf Theunissen <rolf.theunissen@gmail.com>
niraj-modi
added a commit
that referenced
this pull request
Apr 12, 2022
* #6 [win32] Keyboard shortcuts for radio buttons don't work anymore (#24) Change-Id: I09f81bc5041bb1aa61fb7b62300a772aa6853abf Signed-off-by: Rolf Theunissen <rolf.theunissen@gmail.com> * Bug 579626 - RTL text is not rendered correctly on TextLayout #37 Change-Id: I74f0fc34159d2ae6442b501eb2e8038c82c03ac2 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com> Co-authored-by: rolfth <rolf.theunissen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rolf Theunissen rolf.theunissen@gmail.com