New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 577878 - [GTK] Limit Table/Tree drag image to contol's width #3
Bug 577878 - [GTK] Limit Table/Tree drag image to contol's width #3
Conversation
I still think that this should be merged. The simplest reason is that cropping the drag image already occurs on Windows and macOS. The other reason is to avoid super wide drag images, which could easily occur if one column of Table/Tree contains some large string and column auto-sizing is in effect. In this case, drag images for ALL items will be super wide. And super wide drag images could be a usability problem, whereas abrupt content end due to cropping is a marginal beauty problem. |
Can you please rebase locally and push force to your branch? This should prevent from seeing the version error appearing in CI. |
Unfortunately it still fails with error:
This commit does not modify Also, @akurtakov, if you have no objections, I would prefer to merge this patch - see reasoning above. |
Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
According to https://download.eclipse.org/eclipse/downloads/drops4/I20220329-1800/buildlogs/reporeports/reports/versionChecks.html it's an actual check so swt.tools needs version bump. I'll handle it now. |
Let's merge. It's an improvement although not ideal. |
Perfect, thanks! |
…on is not needed This fixes problem eclipse-platform#3 from the snippet (see previous commits) Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
…on is not needed This fixes problem eclipse-platform#3-4 from the snippet (see previous commits) Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
…on is not needed This fixes problem #3-4 from the snippet (see previous commits) Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Continuation from https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/192265