Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 577878 - [GTK] Limit Table/Tree drag image to contol's width #3

Merged
merged 1 commit into from Mar 30, 2022
Merged

Bug 577878 - [GTK] Limit Table/Tree drag image to contol's width #3

merged 1 commit into from Mar 30, 2022

Conversation

SyntevoAlex
Copy link
Member

@SyntevoAlex
Copy link
Member Author

I still think that this should be merged.

The simplest reason is that cropping the drag image already occurs on Windows and macOS.

The other reason is to avoid super wide drag images, which could easily occur if one column of Table/Tree contains some large string and column auto-sizing is in effect. In this case, drag images for ALL items will be super wide. And super wide drag images could be a usability problem, whereas abrupt content end due to cropping is a marginal beauty problem.

@mickaelistria
Copy link
Contributor

Can you please rebase locally and push force to your branch? This should prevent from seeing the version error appearing in CI.

@SyntevoAlex
Copy link
Member Author

Unfortunately it still fails with error:

[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:3.0.0-SNAPSHOT:
compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.swt.tools:
Only qualifier changed for (org.eclipse.swt.tools/3.109.300.v20220329-0614).
Expected to have bigger x.y.z than what is available in baseline (3.109.300.v20211104-1108) -> [Help 1]

This commit does not modify org.eclipse.swt.tools.
@akurtakov is that a migration bug?

Also, @akurtakov, if you have no objections, I would prefer to merge this patch - see reasoning above.

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
@akurtakov
Copy link
Member

According to https://download.eclipse.org/eclipse/downloads/drops4/I20220329-1800/buildlogs/reporeports/reports/versionChecks.html it's an actual check so swt.tools needs version bump. I'll handle it now.

@akurtakov akurtakov merged commit 9e72242 into eclipse-platform:master Mar 30, 2022
@akurtakov
Copy link
Member

Let's merge. It's an improvement although not ideal.

@SyntevoAlex
Copy link
Member Author

Perfect, thanks!

SyntevoAlex added a commit to syntevo/eclipse.platform.swt that referenced this pull request Mar 11, 2023
…on is not needed

This fixes problem eclipse-platform#3 from the snippet (see previous commits)

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
SyntevoAlex added a commit to syntevo/eclipse.platform.swt that referenced this pull request Mar 11, 2023
…on is not needed

This fixes problem eclipse-platform#3-4 from the snippet (see previous commits)

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
SyntevoAlex added a commit that referenced this pull request Mar 11, 2023
…on is not needed

This fixes problem #3-4 from the snippet (see previous commits)

Signed-off-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants