Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jenkins-Build] Fix access of 'skipCommit' pipeline parameter #628

Merged

Conversation

HannesWell
Copy link
Member

The parameter 'skipCommit' was accessed in a interpolated Groovy GString and therefore needs to be accessed via the params-object.

This was forgotten in commit c760d4b but for some reason did not show up in the verification build.

The parameter 'skipCommit' was accessed in a interpolated Groovy GString
and therefore needs to be accessed via the params-object.

This was forgotten in commit c760d4b
but for some reason did not show up in the verification build.
@github-actions
Copy link
Contributor

Test Results

     299 files  ±0       299 suites  ±0   11m 8s ⏱️ + 5m 21s
  4 049 tests ±0    4 037 ✔️  - 1    8 💤 ±0  4 +1 
12 065 runs  ±0  11 991 ✔️  - 1  70 💤 ±0  4 +1 

For more details on these failures, see this check.

Results for commit 0341dfb. ± Comparison against base commit c26d1ff.

@iloveeclipse iloveeclipse merged commit 2d5f082 into eclipse-platform:master Apr 12, 2023
7 of 11 checks passed
@HannesWell HannesWell deleted the fixSkipCommitParameterAccess branch April 12, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants