Use CTabFolder to improve dark theme on Windows #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tabItem.setText(page.getTitle());// | ||
| tabItem.setControl(createPageArea(tabFolder, page)); | ||
| pageMap.put(tabItem, page); | ||
| } | ||
| tabFolder.setSelection(0); |
There was a problem hiding this comment.
With eclipse-platform/eclipse.platform.swt#46 fixed, this line would not be needed.
| folder.setLayout(new TabFolderLayout()); | ||
| folder.setLayoutData(new GridData(GridData.FILL_BOTH)); | ||
|
|
||
| TabItem item= new TabItem(folder, SWT.NONE); | ||
| CTabItem item= new CTabItem(folder, SWT.NONE); | ||
| folder.setSelection(0); |
There was a problem hiding this comment.
With eclipse-platform/eclipse.platform.swt#46 fixed, this line would not be needed.
Torbjorn-Svensson
force-pushed
the
pr/ctabfolder
branch
2 times, most recently
from
fd1112b
to
2a96fb4
Compare
Contributed by STMicroelectronics Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
Torbjorn-Svensson
force-pushed
the
pr/ctabfolder
branch
from
2a96fb4
to
6a5406f
Compare
|
@Torbjorn-Svensson can you post before / after screenshots in this issue? |
Light theme Before: After: Dark theme Before: After: The preference dialog has similar change. |
niraj-modi
approved these changes
Apr 20, 2022
|
This change caused 3 test fails, please adopt either code or tests: eclipse-platform/eclipse.platform.ui#30 |
With only the output below to go on, it's a bit too hard for me to know what's going on. I've spent the past 4h trying to get a runtime for the platform running (just so I could debug the UIComparePreferencesAuto unit-test. I see that there is another class called UIComparePreferences that requires some input from the user. I can run the UIComparePreferences class and it passes, but UIComparePreferencesAuto fails in my runtime with another error: And yes, I'm running it as a "JUnit Plug-in Test" in Eclipse. What I can see is that the method DialogCheck#verifyCompositeText(Composite) might need a copy of the TabFolder block that does the same thing, but with the CTabFolder type instead. As I can't run the unit-test, I don't know if this will make a difference or what button has the label ">". If I manually look in the preference dialog, I do not see any button that has this string. @iloveeclipse: If you have a working runtime, can update DialogCheck#verifyCompositeText(Composite) to look like this and see if it helps with the UIComparePreferencesAuto test case? I think the other 2 failures are unrelated to the UI changes. private static void verifyCompositeText(Composite composite) {
Control children[] = composite.getChildren();
for (Control child : children) {
if (child instanceof TabFolder) {
TabFolder folder = (TabFolder) child;
int numPages = folder.getItemCount();
for (int j = 0; j < numPages; j++) {
folder.setSelection(j);
}
}
else if (child instanceof CTabFolder) {
CTabFolder folder = (CTabFolder) child;
int numPages = folder.getItemCount();
for (int j = 0; j < numPages; j++) {
folder.setSelection(j);
}
}
else if (child instanceof Button) {
//verify the text if the child is a button
verifyButtonText((Button) child);
}
else if (child instanceof Label) {
//child is not a button, maybe a label
verifyLabelText((Label) child);
}
else if (child instanceof Composite) {
//child is not a label, make a recursive call if it is a composite
verifyCompositeText((Composite) child);
}
}
} |
jonahgraham
added a commit
to jonahgraham/eclipse.platform.ui
that referenced
this pull request
Apr 22, 2022
The method verifyCompositeText in DialogCheck verifies various aspects of composites, with eclipse-platform/eclipse.platform.team#14 this now needs to understand CTabFolder (in addition to TabFolder) Also-by: Torbjörn Svensson <torbjorn.svensson@st.com>
jonahgraham
added a commit
to jonahgraham/eclipse.platform.ui
that referenced
this pull request
Apr 22, 2022
The method verifyCompositeText in DialogCheck verifies various aspects of composites, with eclipse-platform/eclipse.platform.team#14 this now needs to understand CTabFolder (in addition to TabFolder) Also-by: Torbjörn Svensson <torbjorn.svensson@st.com>
vogella
pushed a commit
to eclipse-platform/eclipse.platform.ui
that referenced
this pull request
Apr 22, 2022
The method verifyCompositeText in DialogCheck verifies various aspects of composites, with eclipse-platform/eclipse.platform.team#14 this now needs to understand CTabFolder (in addition to TabFolder) Also-by: Torbjörn Svensson <torbjorn.svensson@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributed by STMicroelectronics
Signed-off-by: Torbjörn Svensson torbjorn.svensson@st.com