Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationModel uses both fAnnotations and getAnnotationMap() #19

Closed
iloveeclipse opened this issue May 6, 2022 · 0 comments
Closed
Assignees
Milestone

Comments

@iloveeclipse
Copy link
Member

AnnotationModel.fAnnotations is deprecated and getAnnotationMap() should be used instead.
However I still see the code that uses AnnotationModel.fAnnotations inside AnnotationModel, even together with the getAnnotationMap(). This should be fixed as precondition to fix of inefficient map iterations inside same class.

iloveeclipse added a commit to iloveeclipse/eclipse.platform.text that referenced this issue May 6, 2022
(Fixes eclipse-platform#19)

AnnotationModel.fAnnotations is deprecated and getAnnotationMap() should
be used instead.

However I still see the code that uses AnnotationModel.fAnnotations
inside AnnotationModel, even together with the getAnnotationMap(). This
should be fixed as precondition to fix of inefficient map iterations
inside same class.

eclipse-platform#19
iloveeclipse added a commit to iloveeclipse/eclipse.platform.text that referenced this issue May 6, 2022
(Fixes eclipse-platform#19)

AnnotationModel.fAnnotations is deprecated and getAnnotationMap() should
be used instead.

However I still see the code that uses AnnotationModel.fAnnotations
inside AnnotationModel, even together with the getAnnotationMap(). This
should be fixed as precondition to fix of inefficient map iterations
inside same class.

eclipse-platform#19
@iloveeclipse iloveeclipse self-assigned this May 6, 2022
@iloveeclipse iloveeclipse added this to the 4.24 M3 milestone May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant