delete WorkbenchCommandSupport "API is scheduled for deletion"

fix "overriding a synchronized method without being synchronized"
and several deprecation warnings

bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.commands
-Bundle-Version: 3.11.300.qualifier
+Bundle-Version: 3.12.0.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.core.commands,

bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/common/CommandException.java

@@ -31,12 +31,6 @@ public abstract class CommandException extends Exception {
 	 */
 	private static final long serialVersionUID = 5389763628699257234L;
 
-	/**
-	 * This member variable is required here to allow us to compile against JCL
-	 * foundation libraries.  The value may be <code>null</code>.
-	 */
-	private Throwable cause;
-
 	/**
 	 * Creates a new instance of this class with the specified detail message.
 	 *
@@ -57,20 +51,7 @@ public CommandException(final String message) {
 	 *            the cause; may be <code>null</code>.
 	 */
 	public CommandException(final String message, final Throwable cause) {
-		super(message);
-		// don't pass the cause to super, to allow compilation against JCL Foundation
-		this.cause = cause;
-	}
-
-	/**
-	 * Returns the cause of this throwable or <code>null</code> if the
-	 * cause is nonexistent or unknown.
-	 *
-	 * @return the cause or <code>null</code>
-	 */
-	@Override
-	public Throwable getCause() {
-		return cause;
+		super(message, cause);
 	}
 
 }

bundles/org.eclipse.jface/src/org/eclipse/jface/resource/DeviceResourceException.java

@@ -21,8 +21,6 @@
  */
 public class DeviceResourceException extends RuntimeException {
 
-	private Throwable cause;
-
 	/**
 	 * All serializable objects should have a stable serialVersionUID
 	 */
@@ -36,9 +34,7 @@ public class DeviceResourceException extends RuntimeException {
 	 * @param cause cause of the exception (or null if none)
 	 */
 	public DeviceResourceException(DeviceResourceDescriptor<?> missingResource, Throwable cause) {
-		super("Unable to create resource " + missingResource); //$NON-NLS-1$
-		// don't pass the cause to super, to allow compilation against JCL Foundation (bug 80059)
-		this.cause = cause;
+		super("Unable to create resource " + missingResource, cause); //$NON-NLS-1$
 	}
 
 	/**
@@ -51,16 +47,4 @@ public DeviceResourceException(DeviceResourceDescriptor<?> missingResource) {
 		this(missingResource, null);
 	}
 
-	/**
-	 * Returns the cause of this throwable or <code>null</code> if the
-	 * cause is nonexistent or unknown.
-	 *
-	 * @return the cause or <code>null</code>
-	 * @since 3.1
-	 */
-	@Override
-	public Throwable getCause() {
-		return cause;
-	}
-
 }

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/IWorkbench.java

@@ -23,7 +23,6 @@
 import org.eclipse.ui.activities.IWorkbenchActivitySupport;
 import org.eclipse.ui.browser.IWorkbenchBrowserSupport;
 import org.eclipse.ui.commands.ICommandService;
-import org.eclipse.ui.commands.IWorkbenchCommandSupport;
 import org.eclipse.ui.contexts.IContextService;
 import org.eclipse.ui.contexts.IWorkbenchContextSupport;
 import org.eclipse.ui.handlers.IHandlerService;
@@ -473,21 +472,6 @@ IWorkbenchPage showPerspective(String perspectiveId, IWorkbenchWindow window, IA
 	 */
 	IWorkbenchActivitySupport getActivitySupport();
 
-	/**
-	 * Returns an interface to manage commands at the workbench level.
-	 *
-	 * @return an interface to manage commands at the workbench level. Guaranteed
-	 *         not to be <code>null</code>.
-	 * @since 3.0
-	 * @deprecated Please use {@link IServiceLocator#getService(Class)} instead.
-	 *             This API is scheduled for deletion, see Bug 431177 for details
-	 * @see ICommandService
-	 * @see IHandlerService
-	 * @noreference IWorkbenchCommandSupport is scheduled for deletion.
-	 */
-	@Deprecated
-	IWorkbenchCommandSupport getCommandSupport();
-
 	/**
 	 * Returns an interface to manage contexts at the workbench level.
 	 *