Skip to content

Commit

Permalink
delete WorkbenchCommandSupport "API is scheduled for deletion"
Browse files Browse the repository at this point in the history 
fix "overriding a synchronized method without being synchronized"
and several deprecation warnings
  • Loading branch information
@EcljpseB0T @jukzi
EcljpseB0T authored and jukzi committed Jan 30, 2024
1 parent f0b1071 commit 8cba6db
Show file tree
Hide file tree
Showing 55 changed files with 413 additions and 5,879 deletions.
2 changes: 1 addition & 1 deletion bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.core.commands
Bundle-Version: 3.11.300.qualifier
Bundle-Version: 3.12.0.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package: org.eclipse.core.commands,
Expand Down
21 changes: 1 addition & 20 deletions bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/common/CommandException.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,6 @@ public abstract class CommandException extends Exception {
*/
private static final long serialVersionUID = 5389763628699257234L;

/**
* This member variable is required here to allow us to compile against JCL
* foundation libraries. The value may be <code>null</code>.
*/
private Throwable cause;

/**
* Creates a new instance of this class with the specified detail message.
*
Expand All @@ -57,20 +51,7 @@ public CommandException(final String message) {
* the cause; may be <code>null</code>.
*/
public CommandException(final String message, final Throwable cause) {
super(message);
// don't pass the cause to super, to allow compilation against JCL Foundation
this.cause = cause;
}

/**
* Returns the cause of this throwable or <code>null</code> if the
* cause is nonexistent or unknown.
*
* @return the cause or <code>null</code>
*/
@Override
public Throwable getCause() {
return cause;
super(message, cause);
}

}
18 changes: 1 addition & 17 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/resource/DeviceResourceException.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
*/
public class DeviceResourceException extends RuntimeException {

private Throwable cause;

/**
* All serializable objects should have a stable serialVersionUID
*/
Expand All @@ -36,9 +34,7 @@ public class DeviceResourceException extends RuntimeException {
* @param cause cause of the exception (or null if none)
*/
public DeviceResourceException(DeviceResourceDescriptor<?> missingResource, Throwable cause) {
super("Unable to create resource " + missingResource); //$NON-NLS-1$
// don't pass the cause to super, to allow compilation against JCL Foundation (bug 80059)
this.cause = cause;
super("Unable to create resource " + missingResource, cause); //$NON-NLS-1$
}

/**
Expand All @@ -51,16 +47,4 @@ public DeviceResourceException(DeviceResourceDescriptor<?> missingResource) {
this(missingResource, null);
}

/**
* Returns the cause of this throwable or <code>null</code> if the
* cause is nonexistent or unknown.
*
* @return the cause or <code>null</code>
* @since 3.1
*/
@Override
public Throwable getCause() {
return cause;
}

}
203 changes: 203 additions & 0 deletions bundles/org.eclipse.ui.workbench/.settings/.api_filters
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,203 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<component id="org.eclipse.ui.workbench" version="2">
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.AbstractHandler">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.AbstractHandler"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ActionHandler">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ActionHandler"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.CategoryEvent">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.CategoryEvent"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.CommandEvent">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.CommandEvent"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.CommandException">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.CommandException"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.CommandManagerEvent">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.CommandManagerEvent"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ExecutionException">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ExecutionException"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.HandlerEvent">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.HandlerEvent"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.HandlerSubmission">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.HandlerSubmission"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ICategory">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ICategory"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ICategoryListener">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ICategoryListener"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ICommand">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ICommand"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ICommandListener">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ICommandListener"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ICommandManager">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ICommandManager"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.ICommandManagerListener">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.ICommandManagerListener"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.IHandler">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.IHandler"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.IHandlerListener">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.IHandlerListener"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.IKeyConfiguration">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.IKeyConfiguration"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.IKeyConfigurationListener">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.IKeyConfigurationListener"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.IKeySequenceBinding">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.IKeySequenceBinding"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.IWorkbenchCommandSupport">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.IWorkbenchCommandSupport"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.KeyConfigurationEvent">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.KeyConfigurationEvent"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.NotDefinedException">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.NotDefinedException"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.NotHandledException">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.NotHandledException"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.ui.commands.Priority">
<filter id="305324134">
<message_arguments>
<message_argument value="org.eclipse.ui.commands.Priority"/>
<message_argument value="org.eclipse.ui.workbench_3.131.100"/>
</message_arguments>
</filter>
</resource>
</component>
16 changes: 0 additions & 16 deletions bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/IWorkbench.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.eclipse.ui.activities.IWorkbenchActivitySupport;
import org.eclipse.ui.browser.IWorkbenchBrowserSupport;
import org.eclipse.ui.commands.ICommandService;
import org.eclipse.ui.commands.IWorkbenchCommandSupport;
import org.eclipse.ui.contexts.IContextService;
import org.eclipse.ui.contexts.IWorkbenchContextSupport;
import org.eclipse.ui.handlers.IHandlerService;
Expand Down Expand Up @@ -473,21 +472,6 @@ IWorkbenchPage showPerspective(String perspectiveId, IWorkbenchWindow window, IA
*/
IWorkbenchActivitySupport getActivitySupport();

/**
* Returns an interface to manage commands at the workbench level.
*
* @return an interface to manage commands at the workbench level. Guaranteed
* not to be <code>null</code>.
* @since 3.0
* @deprecated Please use {@link IServiceLocator#getService(Class)} instead.
* This API is scheduled for deletion, see Bug 431177 for details
* @see ICommandService
* @see IHandlerService
* @noreference IWorkbenchCommandSupport is scheduled for deletion.
*/
@Deprecated
IWorkbenchCommandSupport getCommandSupport();

/**
* Returns an interface to manage contexts at the workbench level.
*
Expand Down
Loading

0 comments on commit 8cba6db

Please sign in to comment.