Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set viewer limit to 0 and mark ColumnViewer#setDisplayIncrementally(int incrementSize) as provisional #1030

Closed
raghucssit opened this issue Aug 16, 2023 · 2 comments · Fixed by #1031
Closed

set viewer limit to 0 and mark ColumnViewer#setDisplayIncrementally(int incrementSize) as provisional #1030

raghucssit opened this issue Aug 16, 2023 · 2 comments · Fixed by #1031
Assignees
@iloveeclipse
Milestone
4.29 M3

Comments

@raghucssit
Copy link
Contributor

raghucssit commented Aug 16, 2023 •
edited by iloveeclipse
Loading

As we have observed many issues after enabling viewer limit on platform we will disable the viewer limit for all the viewers configured.
Also mark the ColumnViewer#setDisplayIncrementally(int incrementSize) as provisional

See discussion on #818
raghucssit added a commit to raghucssit/eclipse.platform.ui that referenced this issue Aug 16, 2023
@raghucssit
Disable viewer limit and mark setDisplayIncrementally(int incrementSize)
45566d6 
API as provisional

fixes eclipse-platform#1030
raghucssit added a commit to raghucssit/eclipse.platform.ui that referenced this issue Aug 16, 2023
@raghucssit
Disable viewer limit and mark setDisplayIncrementally(int incrementSize)
6cc83d8 
API as provisional

fixes eclipse-platform#1030
@raghucssit raghucssit mentioned this issue Aug 16, 2023
Merged
@iloveeclipse
Copy link
Member

@raghucssit please don't disable in viewers, only set preference to zero by default

@raghucssit
Copy link
Contributor Author

@raghucssit please don't disable in viewers, only set preference to zero by default

yes. i have set preference to zero

iloveeclipse pushed a commit to raghucssit/eclipse.platform.ui that referenced this issue Aug 16, 2023
@raghucssit @iloveeclipse
Disable viewer limit and mark new API as provisional
97dcc87 
- made isExpandableNode() public to avoid force clients subclassing
Tree/Table viewers that shouldn't be extended.
- added EXPERIMENTAL to isExpandableNode()  / setDisplayIncrementally()
- adopted tests

Fixes eclipse-platform#1030
iloveeclipse pushed a commit to raghucssit/eclipse.platform.ui that referenced this issue Aug 16, 2023
@raghucssit @iloveeclipse
Disable viewer limit and mark new API as provisional
8b69693 
- made isExpandableNode() public to avoid force clients subclassing
Tree/Table viewers that shouldn't be extended.
- added EXPERIMENTAL to
-- isExpandableNode()  / setDisplayIncrementally()
-- IWorkbenchPreferenceConstants.LARGE_VIEW_LIMIT
-- WorkbenchViewerSetup
- adopted tests

Fixes eclipse-platform#1030
@iloveeclipse iloveeclipse self-assigned this Aug 16, 2023
@iloveeclipse iloveeclipse added this to the 4.29 M3 milestone Aug 16, 2023
iloveeclipse pushed a commit that referenced this issue Aug 16, 2023
@raghucssit @iloveeclipse
Disable viewer limit and mark new API as provisional
6d0d4e6 
- made isExpandableNode() public to avoid force clients subclassing
Tree/Table viewers that shouldn't be extended.
- added EXPERIMENTAL to
-- isExpandableNode()  / setDisplayIncrementally()
-- IWorkbenchPreferenceConstants.LARGE_VIEW_LIMIT
-- WorkbenchViewerSetup
- adopted tests

Fixes #1030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
None yet
Projects
None yet
Milestone
4.29 M3
2 participants
@iloveeclipse @raghucssit