Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to resize launcher dialog #165

Closed
vogella opened this issue Jun 21, 2022 · 15 comments · Fixed by #190
Closed

Allow to resize launcher dialog #165

vogella opened this issue Jun 21, 2022 · 15 comments · Fixed by #190

Comments

@vogella
Copy link
Contributor

vogella commented Jun 21, 2022

We have OS / users which cannot use Eclipse due to an incorrectly sized laucher.

https://twitter.com/dadadom/status/1537124038069321729

Any drawbacks in allow the dialog to be re-sized by the user?

image

@laeubi
Copy link
Contributor

laeubi commented Jun 21, 2022

If it is resizable we probably need a different layout (RowLayout?) to account for smaller width.

@laeubi
Copy link
Contributor

laeubi commented Jun 21, 2022

Beside that I really wonder if it makes any sense to use a IDE for such a small screen... but anyways if it makes users happy... why not.

@merks
Copy link
Contributor

merks commented Jun 21, 2022

That just seems silly! Try to shrink the IDE down to that size and then imagine all the fonts are way bigger:

image

@mickaelistria
Copy link
Contributor

That just seems silly! Try to shrink the IDE down to that size and then imagine all the fonts are way bigger:

Remove toolbar & status bar, make fullscreen, expand the editor area so other views are hidden; imagine user uses some voice control application to navigate the IDE and it's actually decent.

@merks
Copy link
Contributor

merks commented Jun 21, 2022

I can also imagine trolls making up excuses just to have something to rag about and to see if they can make other people ask "how high?" when they say "jump".

I'm not sure why we'd put weight into something this marginal when there are literally so many bugs/issues we want to auto close them...

@mickaelistria
Copy link
Contributor

I'm not sure why we'd put weight into something this marginal when there are literally so many bugs/issues we want to auto close them...

It's up to contributors to decide where they put priority. I personally value things like "being able to develop on a phone or a small tablet" more than supporting older versions of Java or other frameworks. YMMV.

vogella added a commit to vogellacompany/eclipse.platform.ui that referenced this issue Jul 5, 2022
Allows to resize the ChooseWorkspaceDialog. We have OS / users which
cannot use Eclipse due to an incorrectly sized launcher. This allows
these users to adjust the workspace dialog.

Fixes eclipse-platform#165
vogella added a commit that referenced this issue Jul 8, 2022
Allows to resize the ChooseWorkspaceDialog. We have OS / users which
cannot use Eclipse due to an incorrectly sized launcher. This allows
these users to adjust the workspace dialog.

Fixes #165
@ronso0
Copy link

ronso0 commented Aug 28, 2022

Would you mind re-opeing this issue?

I'd love to make the dialog wider because with my workspace paths I'm never able to see the entire name, the trailing part is almost always hidden, exactly like the OP illustrates:
image

Possible solutions:

  • allow resizing
  • if that is not feasible, make better use of the available space:
    • remove the space(r) at the right so the path combobox can expand
    • move the path combobox and the "Browse..." button below "Workspace:"

@laeubi
Copy link
Contributor

laeubi commented Aug 29, 2022

Would you mind re-opeing this issue?

Do you plan to provide a patch for this?

* allow resizing

I don't see a reason not to allow this...

* if that is not feasible, make better use of the available space:

We should actually apply both, don't see a reason to not use the available space.

  * remove the space(r) at the right so the path combobox can expand

This sounds reasonable

  * move the path combobox and the "Browse..." button below "Workspace:"

As there is nothing else to select I question if we need the label at all, the description of the dialog gives a quite good explanation what is selected here, so probably we can:

  1. remove the "Workspace" label completely
  2. move the combobox "use this as default" (I think and do not ask again is superfluous) to the button bar, this is how usually such things are presented to the user
  3. always expand the "Recent Workspaces" and move that directly under the Workspace selection

@laeubi laeubi reopened this Aug 29, 2022
@vogella
Copy link
Contributor Author

vogella commented Aug 29, 2022

It is resizable in the next release, can be tested with the latest I-build from https://download.eclipse.org/eclipse/downloads/drops4/I20220828-1800/

image

Please open a new issue for new requirements.

@vogella vogella closed this as completed Aug 29, 2022
@szarnekow
Copy link
Contributor

It is resizable in the next release

Is the screenshot legit? How does it solve the problem in comment 9:

I'd love to make the dialog wider because with my workspace paths I'm never able to see the entire name, the trailing part is almost always hidden

@vogella
Copy link
Contributor Author

vogella commented Aug 29, 2022

@szarnekow It solves the poblem I reported in the original issue report (by me).

@laeubi
Copy link
Contributor

laeubi commented Aug 29, 2022

How does it solve the problem in comment 9:

It all boils down how you define "resizable", as I agree without that it does not really "resizes" from a user POV, technically the dialog itself can be resized (even though the resize is quite useless when you make it larger) so one might argue it is solved...

Anyways, one can simply open a new issue for this, maybe with a more general definition what "resize" means, in web-development one most often refers to "responsive" if a website can adapt to different screensize and/or orientations.

@vogella
Copy link
Contributor Author

vogella commented Aug 29, 2022

The original problem was that the dialog was to small to see the login button in some configurations, that is solved

Resizing the widgets is definitely desired but should be happend in a separate issue.

@laeubi
Copy link
Contributor

laeubi commented Aug 29, 2022

Resizing the widgets is definitely desired but should be happend in a separate issue.

This would be a good example where one can use BorderLayout i'll try to propose a patch...

@ronso0
Copy link

ronso0 commented Aug 29, 2022

Thanks @laeubi for poining out my issue with the dialog.
So are you working on this or should I open a separate issue nonetheless? (Or is there already one? Am not tracking this repo..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants