Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[find/replace logic] cannot easily reset the Incremental Base-Location #1913

Closed
Tracked by #2021
Wittmaxi opened this issue May 31, 2024 · 0 comments · Fixed by #2104 · May be fixed by #1921
Closed
Tracked by #2021

[find/replace logic] cannot easily reset the Incremental Base-Location #1913

Wittmaxi opened this issue May 31, 2024 · 0 comments · Fixed by #2104 · May be fixed by #1921
Labels
bug Something isn't working

Comments

@Wittmaxi
Copy link
Contributor

This Issue Documents a review-comment from the find/replace overlay PR
which could not be addressed into the current proposal
comment

FindReplaceLogic internally keeps track of it's "incremental base location" - when starting a search from a fresh environment, it needs to be set to the current cursor location. However, FindReplaceLogic does not have logic for this, instead only relying on updating the base location when Incremental search is enabled or disabled.
FindReplaceLogic should expose a method for updating an incremental base location instead of relying on a trick to update the Incremental Base Location.
@Wittmaxi Wittmaxi added the bug Something isn't working label May 31, 2024
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 3, 2024
@Wittmaxi
Find/Replace overlay: consistent handling of incremental base location
d3dadba 
Increment the incremental base location consistently, remove method for
"performIncrementalSearch" as it only called "performSearch" and lead to
semantic confusion while calling "performSearch".
- "SearchOptions.REGEX" will now correctly update the incremental base
location once it is disabled.
- Added a method for updating the incremental base location manually
  from outside

fixes eclipse-platform#1914
fixes eclipse-platform#1913
@Wittmaxi Wittmaxi mentioned this issue Jun 3, 2024
Open
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 3, 2024
@Wittmaxi
Find/Replace overlay: consistent handling of incremental base location
d9dd4b5 
Increment the incremental base location consistently, remove method for
"performIncrementalSearch" as it only called "performSearch" and lead to
semantic confusion while calling "performSearch".
- "SearchOptions.REGEX" will now correctly update the incremental base
location once it is disabled.
- Added a method for updating the incremental base location manually
  from outside

fixes eclipse-platform#1914
fixes eclipse-platform#1913
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 10, 2024
@Wittmaxi
Find/Replace overlay: consistent handling of incremental base location
ff1ce9b 
Increment the incremental base location consistently, remove method for
"performIncrementalSearch" as it only called "performSearch" and lead to
semantic confusion while calling "performSearch".
- "SearchOptions.REGEX" will now correctly update the incremental base
location once it is disabled.
- Added a method for updating the incremental base location manually
  from outside

fixes eclipse-platform#1914
fixes eclipse-platform#1913
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 10, 2024
@Wittmaxi
Find/Replace overlay: consistent handling of incremental base location
e4cf14d 
Increment the incremental base location consistently, remove method for
"performIncrementalSearch" as it only called "performSearch" and lead to
semantic confusion while calling "performSearch".
- "SearchOptions.REGEX" will now correctly update the incremental base
location once it is disabled.
- Added a method for updating the incremental base location manually
  from outside

fixes eclipse-platform#1914
fixes eclipse-platform#1913
@Wittmaxi Wittmaxi mentioned this issue Jul 1, 2024
Open
43 tasks
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 5, 2024
@Wittmaxi @HeikoKlare
Find/Replace overlay: consistent handling of incremental base location
c087338 
Increment the incremental base location consistently, remove method for
"performIncrementalSearch" as it only called "performSearch" and lead to
semantic confusion while calling "performSearch".
- "SearchOptions.REGEX" will now correctly update the incremental base
location once it is disabled.
- Added a method for updating the incremental base location manually
  from outside

fixes eclipse-platform#1914
fixes eclipse-platform#1913
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 18, 2024
@Wittmaxi
Find/Replace Logic: Allow reset of Incremental Base Position
67c4e8d 
Allow the client to reset the base position for incremental search
without enabling/disabling the Incremental search.

fixes eclipse-platform#1913
@Wittmaxi Wittmaxi mentioned this issue Jul 18, 2024
Merged
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 19, 2024
@Wittmaxi @HeikoKlare
Find/Replace Logic: Allow reset of Incremental Base Position
ecb803a 
Allow the client to reset the base position for incremental search
without enabling/disabling the Incremental search.

fixes eclipse-platform#1913
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 19, 2024
@Wittmaxi
Find/Replace Logic: Allow reset of Incremental Base Position
f284814 
Allow the client to reset the base position for incremental search
without enabling/disabling the Incremental search.

fixes eclipse-platform#1913
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 19, 2024
@Wittmaxi @HeikoKlare
Find/Replace Logic: Allow reset of Incremental Base Position
c6db852 
Allow the client to reset the base position for incremental search
without enabling/disabling the Incremental search.

fixes eclipse-platform#1913
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 19, 2024
@Wittmaxi
Find/Replace Logic: Allow reset of Incremental Base Position
316c199 
Allow the client to reset the base position for incremental search
without enabling/disabling the Incremental search.

fixes eclipse-platform#1913
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 19, 2024
@Wittmaxi
Find/Replace Logic: Allow reset of Incremental Base Position
37c4cbd 
Allow the client to reset the base position for incremental search
without enabling/disabling the Incremental search.

fixes eclipse-platform#1913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Wittmaxi