Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[find/replace overlay] disabling RegEx resets to the wrong base-location #1915

Closed
Tracked by #2021
Wittmaxi opened this issue May 31, 2024 · 0 comments · Fixed by #2108 · May be fixed by #1921
Closed
Tracked by #2021

[find/replace overlay] disabling RegEx resets to the wrong base-location #1915

Wittmaxi opened this issue May 31, 2024 · 0 comments · Fixed by #2108 · May be fixed by #1921
Labels
bug Something isn't working

Comments

@Wittmaxi
Copy link
Contributor

Wittmaxi commented May 31, 2024

This Issue Documents a review-comment from the find/replace overlay PR
which could not be addressed into the current proposal
comment by @HeikoKlare

disabling the regex search option leads to some unexpected search match being highlighted. If I am not mistaken, it is the one after the incremental base position before enabling the regex option:
grafik

This should be taken into account (and may even implicitly be addressed) when refactoring the way in which the incremental base position is set from outside the FindReplaceLogic. If I understand correctly, the position is reset by disabling and enabling the incremental search option, but that is only a side effect (that does not always apply, like when the regex option is enabled). Probably, resetting the incremental base position when the logic is not (or even cannot) be aware of that necessity should be done in a more explicit way.

@Wittmaxi Wittmaxi added the bug Something isn't working label May 31, 2024
@Wittmaxi Wittmaxi changed the title [find/replace overlay] disabling RegEx leads to wrong base-location [find/replace overlay] disabling RegEx resets to the wrong base-location May 31, 2024
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 18, 2024
Update the incremental Base location even if RegEx is enabled and
incremental search is disabled. Once RegEx is disabled, the incremental
base location is thus still valid.

fixes eclipse-platform#1915
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 18, 2024
Update the incremental Base location even if RegEx is enabled and
incremental search is disabled. Once RegEx is disabled, the incremental
base location is thus still valid.

fixes eclipse-platform#1915
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jul 22, 2024
Update the incremental Base location even if RegEx is enabled and
incremental search is disabled. Once RegEx is disabled, the incremental
base location is thus still valid.

fixes eclipse-platform#1915
Wittmaxi added a commit that referenced this issue Jul 22, 2024
…2108)

Update the incremental Base location even if RegEx is enabled and
incremental search is disabled. Once RegEx is disabled, the incremental
base location is thus still valid.

fixes #1915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant