-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[find/replace overlay] disabling RegEx resets to the wrong base-location #1915
Closed
Tracked by
#2021
Labels
bug
Something isn't working
Comments
43 tasks
Wittmaxi
added a commit
to Wittmaxi/eclipse.platform.ui
that referenced
this issue
Jul 18, 2024
Update the incremental Base location even if RegEx is enabled and incremental search is disabled. Once RegEx is disabled, the incremental base location is thus still valid. fixes eclipse-platform#1915
Wittmaxi
added a commit
to Wittmaxi/eclipse.platform.ui
that referenced
this issue
Jul 18, 2024
Update the incremental Base location even if RegEx is enabled and incremental search is disabled. Once RegEx is disabled, the incremental base location is thus still valid. fixes eclipse-platform#1915
Wittmaxi
added a commit
to Wittmaxi/eclipse.platform.ui
that referenced
this issue
Jul 22, 2024
Update the incremental Base location even if RegEx is enabled and incremental search is disabled. Once RegEx is disabled, the incremental base location is thus still valid. fixes eclipse-platform#1915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This Issue Documents a review-comment from the find/replace overlay PR
which could not be addressed into the current proposal
comment by @HeikoKlare
disabling the regex search option leads to some unexpected search match being highlighted. If I am not mistaken, it is the one after the incremental base position before enabling the regex option:
![grafik](https://private-user-images.githubusercontent.com/16443184/335660670-8765c824-7599-4959-b12c-4cfb6756bed9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3MTI2OTMsIm5iZiI6MTcyMTcxMjM5MywicGF0aCI6Ii8xNjQ0MzE4NC8zMzU2NjA2NzAtODc2NWM4MjQtNzU5OS00OTU5LWIxMmMtNGNmYjY3NTZiZWQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDA1MjYzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRkYmNjZDg3N2ZjMjIxNjg0N2E4MGQ2MzZhMWU0Y2MzNTNiOTNhMjg4M2FhOTY3M2FhMmViZmM1ZjM4MjAxODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QB9QWPAEGbo4PVsWLmmxVWgYz2gOcNY5Vvxa1j_DWFQ)
This should be taken into account (and may even implicitly be addressed) when refactoring the way in which the incremental base position is set from outside the FindReplaceLogic. If I understand correctly, the position is reset by disabling and enabling the incremental search option, but that is only a side effect (that does not always apply, like when the regex option is enabled). Probably, resetting the incremental base position when the logic is not (or even cannot) be aware of that necessity should be done in a more explicit way.
The text was updated successfully, but these errors were encountered: