Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser default preference for internal/external ignores plugin customization #331

Closed
trancexpress opened this issue Sep 12, 2022 · 0 comments · Fixed by #332
Closed

Browser default preference for internal/external ignores plugin customization #331

trancexpress opened this issue Sep 12, 2022 · 0 comments · Fixed by #332
Assignees
@trancexpress
Labels
regression
Milestone
4.26 M1

Comments

@trancexpress
Copy link
Contributor

A regression from: a2b2589

https://bugs.eclipse.org/bugs/show_bug.cgi?id=577081

We use the following in a -pluginCustomization file:

org.eclipse.ui.browser/browser-choice=0

When resetting defaults, the setting in plugin customization is ignored.
@iloveeclipse iloveeclipse added this to the 4.26 M1 milestone Sep 12, 2022
trancexpress added a commit to trancexpress/eclipse.platform.ui that referenced this issue Sep 12, 2022
@trancexpress
Fix plugin customization for internal/external browser default eclips…
b4863b0 
…e-platform#331

Adjusted the Web Browser preference page to respect defaults passed via
-pluginCustomization file.

Fixes: eclipse-platform#331
@trancexpress trancexpress mentioned this issue Sep 12, 2022
Merged
iloveeclipse pushed a commit that referenced this issue Sep 12, 2022
@trancexpress @iloveeclipse
Fix plugin customization for internal/external browser default #331
57c7343 
Adjusted the Web Browser preference page to respect defaults passed via
-pluginCustomization file.

Fixes: #331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trancexpress trancexpress

Labels
regression
Projects
None yet
Milestone
4.26 M1
Development

Successfully merging a pull request may close this issue.

Fix plugin customization for internal/external browser default #331 trancexpress/eclipse.platform.ui
2 participants
@iloveeclipse @trancexpress