Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtendedMarkersView doesn't consider ViewerFilter when using Limit #345

Open
eobrienPilz opened this issue Sep 20, 2022 · 3 comments
Open

Comments

@eobrienPilz
Copy link
Contributor

eobrienPilz commented Sep 20, 2022

If there is a ViewerFilter applied to the ExtendedMarkersView MarkersTreeViewer then the limit on the ExtendedMarkersView doesn't work as you would expect. The limit is applied to all of the markers before the viewer filter is applied. As a result it means markers can go missing from the Marker support view.

see the screenshot.
LimitWithViewerFilter

This shows a view that only displays red markers (using a viewer filter). A workspace with 4 red and 4 blue markers and a marker limit set to 5. Only 1 red markers makes it into the view as the limit removes the others.

2 failing tests showing the above case: #346

eobrienPilz added a commit to eobrienPilz/eclipse.platform.ui that referenced this issue Sep 20, 2022
laeubi pushed a commit to eobrienPilz/eclipse.platform.ui that referenced this issue Oct 17, 2022
eobrienPilz added a commit to eobrienPilz/eclipse.platform.ui that referenced this issue Oct 19, 2022
@jukzi
Copy link
Contributor

jukzi commented Oct 27, 2022

@eobrienPilz Tests look good. can you provide a fix?

@eobrienPilz
Copy link
Contributor Author

I don't have a fix off hand. I am going to wait until some of my outstanding merge requests get landed before investigating more.

@mickaelistria
Copy link
Contributor

FWIW, bugfix patches usually get merged much faster than feature/API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants