-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtendedMarkersView doesn't consider ViewerFilter when using Limit #345
Comments
eobrienPilz
added a commit
to eobrienPilz/eclipse.platform.ui
that referenced
this issue
Sep 20, 2022
…kersView .. Limit
laeubi
pushed a commit
to eobrienPilz/eclipse.platform.ui
that referenced
this issue
Oct 17, 2022
…kersView .. Limit
eobrienPilz
added a commit
to eobrienPilz/eclipse.platform.ui
that referenced
this issue
Oct 19, 2022
…kersView .. Limit
@eobrienPilz Tests look good. can you provide a fix? |
I don't have a fix off hand. I am going to wait until some of my outstanding merge requests get landed before investigating more. |
FWIW, bugfix patches usually get merged much faster than feature/API changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If there is a ViewerFilter applied to the ExtendedMarkersView MarkersTreeViewer then the limit on the ExtendedMarkersView doesn't work as you would expect. The limit is applied to all of the markers before the viewer filter is applied. As a result it means markers can go missing from the Marker support view.
see the screenshot.
![LimitWithViewerFilter](https://user-images.githubusercontent.com/58333578/191249220-ed1747dc-e5b6-4406-a041-1b2d9e8b41f0.png)
This shows a view that only displays red markers (using a viewer filter). A workspace with 4 red and 4 blue markers and a marker limit set to 5. Only 1 red markers makes it into the view as the limit removes the others.
2 failing tests showing the above case: #346
The text was updated successfully, but these errors were encountered: