Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Toolbar background color vanished - toolbar rendering ugly #536

Open
de-jcup opened this issue Jan 30, 2023 · 10 comments · May be fixed by #538
Open

Dark mode: Toolbar background color vanished - toolbar rendering ugly #536

de-jcup opened this issue Jan 30, 2023 · 10 comments · May be fixed by #538

Comments

@de-jcup
Copy link

de-jcup commented Jan 30, 2023

Situation

The background color changes in eclipse 2022-12 in multiple views

When I start eclipse on my Linux Mint machine (GTK) I see
image

When I select something inside the tree (e.g. a Java project) The background color changes (and looks and keeps ugly after this):
image

I think this is related to #467

The console view does always show the wrong (ugly) background behavior.
@de-jcup de-jcup changed the title Dark mode: Toolbar background color vanishing - Icons look ugly Dark mode: Toolbar background color vanished - toolbar rendering ugly Jan 30, 2023
@akurtakov
Copy link
Member

Committers that used to work on dark theme are no longer that active so help is required in this area.

@de-jcup
Copy link
Author

de-jcup commented Jan 30, 2023

Hmm... tried out oomp-installer + platform IDE - starting Eclipse 2023-03 (master) I had following:

image

The toolbar icons are now correct rendered with Theme "dark". Navigator and console view are looking good now/again.

So I think this has been already fixed for 2023-03 ? Shall I close the issue?

@akurtakov
Copy link
Member

At least I'm not aware of any fix in that area in this cycle. Have you started with new workspace aka smth bad being cached up? Could it be some additional plugin installed causing issues with theming? I'm only guessing here.

@de-jcup
Copy link
Author

de-jcup commented Jan 30, 2023

Oh. It is still a problem. It was only correct rendered, because the toolbar was "on top". When reducing the size of the window, the toolbar is no longer rendered with the light grey background, but uses the dark one - this is also the problem with the not visible toggle situation from #467 : The Border has the same color like the dark background - so border for selection becomes invisible.
image

@de-jcup
Copy link
Author

de-jcup commented Jan 30, 2023

@akurtakov

I temporarily changed the css syling in e4-dark_globalstyle.css

ToolBar {
/*	background-color:inherit;	*/
/*    background-color: #ff0000;*/
    background-color: '#org-eclipse-ui-workbench-DARK_BACKGROUND'
}

And I think this looks good:

image

image

I could create a PR for this.

I think this will fix #467 as well (maybe there should be a dedicated border color but at least the toggle state is visible again)

@akurtakov
Copy link
Member

please submit a PR so more people test it.

de-jcup added a commit to de-jcup/eclipse.platform.ui that referenced this issue Jan 30, 2023
@de-jcup
Fix toolbar render problems in dark mode on resizing eclipse-platform…
71de89c 
…#536

- Toolbar has in dark mode now a dedicated color
  instead of css inheritance. A parent container
  change by resizing does not change the toolbar color any longer
- The color is choosen in way that the main toolbar looks as expected
  before. Also the toggle border is now visible again, which could
  address eclipse-platform#467 as well.

Signed-off-by: Albert Tregnaghi <albert.tregnaghi@gmail.com>
@de-jcup de-jcup linked a pull request Jan 30, 2023 that will close this issue
Draft
de-jcup added a commit to de-jcup/eclipse.platform.ui that referenced this issue Jan 30, 2023
@de-jcup
Fix toolbar render problems in dark mode on resizing eclipse-platform…
e81b94f 
…#536

- Toolbar has in dark mode now a dedicated color
  instead of css inheritance. A parent container
  change by resizing does not change the toolbar color any longer
- The color is choosen in way that the main toolbar looks as expected
  before. Also the toggle border is now visible again, which could
  address eclipse-platform#467 as well.

Signed-off-by: Albert Tregnaghi <albert.tregnaghi@gmail.com>
@de-jcup
Copy link
Author

de-jcup commented Jan 30, 2023

@akurtakov - I created PR #536

@akurtakov
Copy link
Member

I seem to be able to get the old rendering by clicking on e.g. buttons in Outline view:
image

@de-jcup
Copy link
Author

de-jcup commented Jan 31, 2023

Yes. I can reproduce it. (remark: when you resize the outline window it is correct rendered again)
I will investigate more and try to fix this as well.

@akurtakov
Copy link
Member

OK, I'll resist merging this one as it's not clearly fixing the issue.

de-jcup added a commit to de-jcup/eclipse.platform.ui that referenced this issue Feb 4, 2023
@de-jcup
Changed CSS background handling for ToolItem + CTabFolder eclipse-pla…
1693cb7 
…tform#536

- removed CSS background handling for ToolItem + changed tests
  (temporary as long as there are conflicts)
- handled CTabFolder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix toolbar render problems in dark mode on resizing #536 de-jcup/eclipse.platform.ui
2 participants
@akurtakov @de-jcup