Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand an expandable node once it is visible. #1057

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Expand an expandable node once it is visible. #1057

wants to merge 1 commit into from

Conversation

raghucssit
Copy link
Contributor

@raghucssit raghucssit commented Aug 22, 2023 •
edited
Loading

It will calculate the location of expandable node, once it enters visible area of Viewer expand it.

Fixes #1041

@raghucssit raghucssit marked this pull request as draft August 22, 2023 08:44
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023 •
edited
Loading

Test Results

     849 files   -        2       849 suites   - 2   1h 27m 11s ⏱️ - 15m 10s
  5 771 tests  - 1 557    5 730 ✔️  - 1 444    30 💤  - 122  11 ❌ +  9 
18 459 runs   - 3 114  18 293 ✔️  - 2 899  133 💤  - 246  33 ❌ +31 

For more details on these failures, see this check.

Results for commit f7980cf. ± Comparison against base commit ffb0cdc.

This pull request removes 1557 tests. 
org.eclipse.ui.internal.ide.ChooseWorkspaceDialogTests ‑ testFilterDuplicatedPaths
org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ fileSeparatorOpensProposalPopup
org.eclipse.ui.internal.ide.DirectoryProposalContentAssistTest ‑ opensProposalPopupWithSubfoldersAsProposals
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAll
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksAndEndTerminator
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksForGaps
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testAstersisksForOneGap
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testCapitalizedText
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testCaseInsensitivity
org.eclipse.ui.tests.StyledStringHighlighterTest ‑ testEndTerminator
…

♻️ This comment has been updated with latest results.

mickaelistria
mickaelistria reviewed Aug 22, 2023
View reviewed changes
bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TableViewer.java Outdated
@@ -118,8 +122,65 @@ public TableViewer(Composite parent, int style) {
public TableViewer(Table table) {
this.table = table;
hookControl(table);
// listen to tree resizes.
table.addControlListener(new ControlListener() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be added only when setInncrementalDisplay is invoked with a value > 0 (and removed if value is then set to 0) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.. i will fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickaelistria I have fixed it. Also I have modified the listener to honor only one expansion per scroll bar drag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

@mickaelistria mickaelistria mentioned this pull request Aug 22, 2023
Open
@raghucssit raghucssit force-pushed the incr-display-on-visib-exp branch 2 times, most recently from cee81b4 to 500fe10 Compare August 24, 2023 14:47
@raghucssit
Expand an expandable node once it is visible.
f7980cf 
It will calculate the location of expandable node, once it enters
visible area of Viewer expand it.
Install resize listener for control when limit is set and remove limit
is reset.Do the same thing for Vertical Scroll bar control.
Honor the entire drag event as one selection at the end of the drag.

see eclipse-platform#818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelistria mickaelistria mickaelistria left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SoftLimit: allow "show..." node to be auto-expanded when visible or soon visible
2 participants
@raghucssit @mickaelistria