Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove form customization from System theme #111

Merged

Conversation

mickaelistria
Copy link
Contributor

Stick to default form, if those needs tweak it's better to try
implementing them directly in the Form than in the theme.

Stick to default form, if those needs tweak it's better to try
implementing them directly in the Form than in the theme.
@vogella
Copy link
Contributor

vogella commented Jun 8, 2022

+1

But as the gradient looks so ugly in forms it would be great if you could also change the default in forms to use a solid color.

@mickaelistria
Copy link
Contributor Author

But as the gradient looks so ugly in forms it would be great if you could also change the default in forms to use a solid color.

That was my initial goal with that part of the theme, but it appeared that customizing with theme leads to some bugs (eg section text not readable). I'll try to work on the gradient some time later.

@vogella
Copy link
Contributor

vogella commented Jun 8, 2022

But as the gradient looks so ugly in forms it would be great if you could also change the default in forms to use a solid color.

That was my initial goal with that part of the theme, but it appeared that customizing with theme leads to some bugs (eg section text not readable). I'll try to work on the gradient some time later.

Thanks. I opened #114 would be nice to move forms to a less Win95 L&F.

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks finally usable.

@mickaelistria mickaelistria merged commit 2ca43c8 into eclipse-platform:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants