Store properties dialog bounds. #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 900 files ±0 900 suites ±0 46m 0s ⏱️ -1s For more details on these failures, see this check. Results for commit ab22a44. ± Comparison against base commit 01ae9f9. ♻️ This comment has been updated with latest results. |
BeckerWdf
approved these changes
Nov 7, 2023
marcushoepfner
force-pushed
the
properties_dialog_bound_settings
branch
2 times, most recently
from
c59bf33
to
27778d9
Compare
marcushoepfner
force-pushed
the
properties_dialog_bound_settings
branch
from
27778d9
to
826cd04
Compare
BeckerWdf
reviewed
Dec 5, 2023
| @Override | ||
| protected IDialogSettings getDialogBoundsSettings() { | ||
| Bundle bundle = WorkbenchPlugin.getDefault().getBundle(); | ||
| IDialogSettings settings = PlatformUI.getDialogSettingsProvider(bundle).getDialogSettings(); |
There was a problem hiding this comment.
can't settings also be null here?
There was a problem hiding this comment.
ah no. It look like null is never returned
BeckerWdf
approved these changes
Dec 5, 2023
| @Override | ||
| protected IDialogSettings getDialogBoundsSettings() { | ||
| Bundle bundle = WorkbenchPlugin.getDefault().getBundle(); | ||
| IDialogSettings settings = PlatformUI.getDialogSettingsProvider(bundle).getDialogSettings(); |
There was a problem hiding this comment.
ah no. It look like null is never returned
BeckerWdf
force-pushed
the
properties_dialog_bound_settings
branch
from
826cd04
to
c4864aa
Compare
|
One of the failing test is unrelated. See: #811 |
Properties dialog is created and shown when 'Properties' action is performed while an object is selected. (e.g. in Project Explorer) Issue eclipse-platform#949
marcushoepfner
force-pushed
the
properties_dialog_bound_settings
branch
from
c4864aa
to
ab22a44
Compare
marcushoepfner
merged commit 8abe1b1
into
eclipse-platform:master
14 of 16 checks passed
marcushoepfner
added a commit
to marcushoepfner/eclipse.platform.ui
that referenced
this pull request
Dec 7, 2023
marcushoepfner
added a commit
to marcushoepfner/eclipse.platform.ui
that referenced
this pull request
Dec 11, 2023
jukzi
pushed a commit
to jukzi/eclipse.platform.ui
that referenced
this pull request
Jun 5, 2024
This reverts commit 8abe1b1. The PreferenceDialog has a custom size calculation that tries to adapt to the current page. That contradicts using the the former size
jukzi
pushed a commit
to jukzi/eclipse.platform.ui
that referenced
this pull request
Jun 5, 2024
…eclipse-platform#1895 This reverts commit 8abe1b1. The PreferenceDialog has a custom size calculation that tries to adapt to the current page. That contradicts using the the former size eclipse-platform#1895
jukzi
pushed a commit
to jukzi/eclipse.platform.ui
that referenced
this pull request
Jun 5, 2024
…eclipse-platform#1895 This reverts commit 8abe1b1. The PreferenceDialog has a custom size calculation that tries to adapt to the current page. That contradicts using the the former size eclipse-platform#1895
jukzi
pushed a commit
to jukzi/eclipse.platform.ui
that referenced
this pull request
Jun 5, 2024
…eclipse-platform#1895 This reverts commit 8abe1b1. The PreferenceDialog has a custom size calculation that tries to adapt to the current page. That contradicts using the the former size eclipse-platform#1895
jukzi
pushed a commit
to jukzi/eclipse.platform.ui
that referenced
this pull request
Jun 6, 2024
…eclipse-platform#1895 This reverts commit 8abe1b1. The PreferenceDialog has a custom size calculation that tries to adapt to the current page. That contradicts using the the former size eclipse-platform#1895
jukzi
pushed a commit
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propeties dialog is created and shown when 'Properties' action is performed while an object is selected. (e.g. in Project Explorer)
Issue #949